fix: update bindgen for Clang type definitions - #135
Closed
jaagut wants to merge 1 commit into
Closed
Conversation
Author
|
Sorry, I did not meant to push this. This is a duplicate of #133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang's changed handling of type declarations can cause bindgen to emit opaque ROS type-support structs, leaving r2r's message generator unable to access their fields. Update bindgen in all four consumers to the release containing the upstream Clang compatibility fix: https://github.com/rust-lang/rust-bindgen/releases/tag/v0.72.1.
Keeping r2r_common, r2r_rcl, r2r_msg_gen, and r2r_actions on the same bindgen version preserves compatibility of the Builder and Bindings types passed between them.
Validation so far: the equivalent dependency-only change based on r2r 0.9.5 builds the Bit-Bots extrinsic calibration package against ROS Jazzy and libclang 22, without its previous vendored r2r_msg_gen workaround. Generated rosidl_message_type_support_t bindings expose the data field correctly. This PR applies that change to current master; the full upstream test matrix has not been run locally.