[UIK-5092][d3-chart] added responsiveness for charts by default#2983
Open
ilyabrower wants to merge 21 commits into
Open
[UIK-5092][d3-chart] added responsiveness for charts by default#2983ilyabrower wants to merge 21 commits into
ilyabrower wants to merge 21 commits into
Conversation
ilyabrower
force-pushed
the
UIK-5092/reposiveness-charts
branch
from
86b79f3 to
3e2482f
Compare
….com/semrush/intergalactic into UIK-5092/reposiveness-charts
j-mnizhek
approved these changes
Jun 12, 2026
j-mnizhek
left a comment
j-mnizhek
left a comment
Member
There was a problem hiding this comment.
Cool!
- Updated chart documentation to clarify that charts are responsive by default
- Added a story demonstrating responsive charts by default
- Updated story names for responsive charts + links in test files
ilyabrower
commented
Jun 12, 2026
| return ( | ||
| <Chart.Area | ||
| w='100%' | ||
| h={200} |
Contributor
Author
There was a problem hiding this comment.
I think it's better to add a wrapper here. In real apps, users will specify the sizes of parent elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/d3-chart
Added
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: