[ticket-088] fix(ci): validate the GitHub event commit range - #129
Conversation
There was a problem hiding this comment.
Deterministic Validator approval for exact head d1f8386177d629a1a244b5d0a47bad5bf45270cd.
Ticket: ticket-088
Correlation ID: goal-ci-push-base-088
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Change adds WELLMANIFEST_BASE_SHA env binding (PR base sha or push before sha) to the test step in ci.yml, plus ticket-088 documentation and intent metadata. All checks pass. The workflow change is minimal, matches the stated intent, and does not weaken gates.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Actual PR impact radar
Exact range: 64d230b2526fec5c90f4c1a842923e37dd56789c...d1f8386177d629a1a244b5d0a47bad5bf45270cd
Change digest: cfc958cddcde61ed7e52d1015e4f483a23344848c7609bc40831f43f1ad45cc6
Score: 44/100 (M), estimated 39 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":99,"base_sha":"64d230b2526fec5c90f4c1a842923e37dd56789c","binary_files":0,"categories":{"configuration":2,"docs":1},"change_digest":"cfc958cddcde61ed7e52d1015e4f483a23344848c7609bc40831f43f1ad45cc6","comparison":"64d230b2526fec5c90f4c1a842923e37dd56789c...d1f8386177d629a1a244b5d0a47bad5bf45270cd","deletions":0,"file_count":3,"files":["github/workflows/ci.yml","project/ticket-088/README.md","project/ticket-088/intent.json"],"head_sha":"d1f8386177d629a1a244b5d0a47bad5bf45270cd","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":1,"uncertainty":4,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":39,"within_budget":false},"impact":{"components":["github","project"],"files":["github/workflows/ci.yml","project/ticket-088/README.md","project/ticket-088/intent.json"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":44,"split":{"parts":[{"estimated_minutes":15,"name":"Implement github","scope":["github"]},{"estimated_minutes":15,"name":"Implement project","scope":["project"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-088"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-088: [ticket-088] fix(ci): validate the GitHub event commit range</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,55 89,56 84,92 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 39m</text></svg>DECISION D-088-4575
TICKET ticket-088
HEAD_SHA d1f8386177d629a1a244b5d0a47bad5bf45270cd
CORRELATION_ID goal-ci-push-base-088
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / remote lifecycle=PASS","test (3.13)=PASS","governance / enforce=PASS","test (3.12)=PASS"]
INPUT required_checks = ["test (3.12)","test (3.13)"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"64d230b2526fec5c90f4c1a842923e37dd56789c","head_sha":"d1f8386177d629a1a244b5d0a47bad5bf45270cd","change_digest":"cfc958cddcde61ed7e52d1015e4f483a23344848c7609bc40831f43f1ad45cc6","score":44,"complexity":"M","estimated_minutes":39,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Created by governed goal -a pull-request delivery.