Skip to content

chore(sync): adopt canonical bridge from vscode_client - #128

Merged
DontBlameMeDev merged 1 commit into
mainfrom
t3/fa76005d-sync
Nov 20, 2026
Merged

DontBlameMeDev merged 1 commit into
mainfrom
t3/fa76005d-sync

Conversation

@DontBlameMeDev

@DontBlameMeDev DontBlameMeDev commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

The workspace contract check found web_client's vendored src/bridge/grant.ts drifting after vscode_client PR #204. This PR brings the canonical copies back into agreement.

scripts/sync-engine.sh was run against the canonical trees at vscode_client origin/main (3a41c877140b764fa7226d326a875f92197674fd). Only src/bridge/grant.ts changed; there were no web-client-local vendor edits to preserve. The recorded upstream SHA in the sync script was updated and dist/ was regenerated. The canonical change hoists the path encoder, uses a set for binary suffixes, skips UTF-8 counting for short paths, and short-circuits ignore checks with no sources.

Proof:

  • Before, with web_client at 2f34bb0e153632331ef0bca9ce24e63334a312de and all other repos at origin/main, the scoped check reported workspace: 4 comparisons, 1 drifted, 0 errors and drift: web_client/src/bridge <- vscode_client/src/bridge / added, deleted, or changed: grant.ts.
  • After, with web_client at the candidate commit and all other repos at origin/main, the same scoped check reports workspace: 4 comparisons, 0 drifted, 0 errors. The full 20-comparison check has 2 remaining drifts, both in other repos (nvim_client and mcp vendor bridges), which this repo cannot fix.
  • scripts/sync-engine.sh against the canonical origin/main tree reports src/{engine,bridge} match, and diff -r finds no differences.
  • npm run typecheck passes; npm test 898/898 pass; scripts/ci-local.sh all passes end to end, including the byte-reproducible dist/ check and 18/18 links.

Reviewed with review-loop: 1 round with opencode-go/hy4-flash-free. verdict: approved

Created with opencode-go/hy4-flash-free in Pi (T3 Code), including the review subagent.

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of paths near the 4,096-byte limit, including paths whose encoded size differs from their character count.
    • Binary-file checks now use the final filename extension; filenames consisting only of an extension are not treated as binary.
    • Paths are no longer marked as ignored when no ignore sources are provided.

The workspace contract found src/bridge/grant.ts drifting after vscode_client PR #204. Sync src/engine and src/bridge from vscode_client origin/main (3a41c877) and record the new upstream SHA.
Copilot AI balanced review requested due to automatic review settings November 20, 2026 02:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The grant code now checks binary path extensions and UTF-8 path length with updated logic, and returns early when no ignore sources are present. The recorded upstream vscode_client SHA also changed.

Changes: Bridge grant update

Layer / File(s) Summary
Grant path checks and upstream revision
src/bridge/grant.ts, scripts/sync-engine.sh
isBinaryNamedPath checks the final extension against a Set. isGrantedPath encodes paths only when needed to check the 4096-byte limit. isIgnoredPath returns false when no ignore sources are present. The recorded upstream SHA changed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Suggested reviewers: claude

Merge Risk: Minimal · up to 1f454

This syncs the vendored bridge code with the upstream version through small performance-oriented refactors that preserve existing behavior. No concrete merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "chore(sync): adopt canonical bridge from vscode_client" names the main change. The PR syncs the vendored src/bridge from the canonical vscode_client at origin/main, and the raw summary conf…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore(sync): adopt canonical bridge from vscode_client" names the main change. The PR syncs the vendored src/bridge from the canonical vscode_client at origin/main, and the raw summary confirms the bridge changes in src/bridge/grant.ts. The title is short, specific, and uses a conventional commit prefix. It does not mention the updated sync-engine.sh SHA or the regenerated dist/, which is acceptable because it is not the primary change.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 10420025-0695-452e-9db4-6c4fc708ea06
Commits

Reviewing files that changed from the base of the PR and between 2f34bb0 and 1f454fa.

Files ignored due to path filters: 2

  • dist/app.js is excluded by !**/dist/**
  • dist/app.js.map is excluded by !**/dist/**, !**/*.map
Files selected for processing: 2

  • scripts/sync-engine.sh
  • src/bridge/grant.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

@DontBlameMeDev
DontBlameMeDev merged commit c0e31cc into main Nov 20, 2026
8 checks passed
@DontBlameMeDev
DontBlameMeDev deleted the t3/fa76005d-sync branch November 20, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants