Repository navigation
chore(sync): adopt canonical bridge from vscode_client - #128
Conversation
The workspace contract found src/bridge/grant.ts drifting after vscode_client PR #204. Sync src/engine and src/bridge from vscode_client origin/main (3a41c877) and record the new upstream SHA.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The workspace contract check found web_client's vendored
src/bridge/grant.tsdrifting after vscode_client PR #204. This PR brings the canonical copies back into agreement.scripts/sync-engine.shwas run against the canonical trees at vscode_clientorigin/main(3a41c877140b764fa7226d326a875f92197674fd). Onlysrc/bridge/grant.tschanged; there were no web-client-local vendor edits to preserve. The recorded upstream SHA in the sync script was updated anddist/was regenerated. The canonical change hoists the path encoder, uses a set for binary suffixes, skips UTF-8 counting for short paths, and short-circuits ignore checks with no sources.Proof:
2f34bb0e153632331ef0bca9ce24e63334a312deand all other repos atorigin/main, the scoped check reportedworkspace: 4 comparisons, 1 drifted, 0 errorsanddrift: web_client/src/bridge <- vscode_client/src/bridge / added, deleted, or changed: grant.ts.origin/main, the same scoped check reportsworkspace: 4 comparisons, 0 drifted, 0 errors. The full 20-comparison check has 2 remaining drifts, both in other repos (nvim_clientandmcpvendor bridges), which this repo cannot fix.scripts/sync-engine.shagainst the canonicalorigin/maintree reportssrc/{engine,bridge} match, anddiff -rfinds no differences.npm run typecheckpasses;npm test898/898 pass;scripts/ci-local.sh allpasses end to end, including the byte-reproducibledist/check and 18/18 links.Reviewed with review-loop: 1 round with opencode-go/hy4-flash-free. verdict: approved
Created with opencode-go/hy4-flash-free in Pi (T3 Code), including the review subagent.
Summary by CodeRabbit