fix(scenarios): use -internal aggregate Service for TM RPC/REST endpoints#294
Merged
Conversation
…ints
The major-upgrade scenario's bash steps (compute-target-height,
resolve-proposal-id, wait-for-proposal-to-pass) curl Tendermint
endpoints at \${SEI_DEPLOYMENT}-0.\${SEI_NAMESPACE}.svc.cluster.local
on ports 26657 (RPC) and 1317 (REST). This dies with:
curl: (7) Failed to connect to bench-major-upgrade-X-0.nightly.svc:26657:
Could not connect to server
Root cause: per-pod Services on a SeiNodeDeployment expose ONLY the EVM
ports (8545/8546). Tendermint RPC (26657) and REST (1317) are surfaced
ONLY via the deployment-scoped \`<snd-name>-internal\` aggregate Service
(see SeiNodeDeployment.status.internalService + .endpoints.{tendermintRpc,
tendermintRest}).
Concretely from a recent SND status:
tendermintRpc: http://<snd-name>-internal.nightly.svc:26657
tendermintRest: http://<snd-name>-internal.nightly.svc:1317
Change all three bash steps to use the -internal aggregate Service.
TM RPC/REST are stateless query endpoints so the aggregate (any
healthy validator) is the right target.
Symptom chain on the live harbor run that caught this:
- compute-target-height failed with curl rc=7 (connection refused)
- workflow-vars ConfigMap never got created
- downstream submit-upgrade-proposal step waited as a
CreateContainerConfigError because its \`envFrom: configMapRef\`
pointed at a ConfigMap that didn't exist
Single fix at the source resolves the whole cascade.
|
You have used all Bugbot PR reviews included in your free trial for your GitHub account on this workspace. To continue using Bugbot reviews, enable Bugbot for your team in the Cursor dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The major-upgrade scenario's bash steps (compute-target-height, resolve-proposal-id, wait-for-proposal-to-pass) curl Tendermint endpoints at per-pod Service DNS:
```
http://${SEI_DEPLOYMENT}-0.${SEI_NAMESPACE}.svc.cluster.local:26657/status
http://${SEI_DEPLOYMENT}-0.${SEI_NAMESPACE}.svc.cluster.local:1317/cosmos/...
```
On the live harbor manual run this dies with:
```
curl: (7) Failed to connect to bench-major-upgrade-X-0.nightly.svc:26657:
Could not connect to server
```
Root cause
Per-pod Services on a SeiNodeDeployment expose only the EVM ports (8545/8546). Tendermint RPC (26657) and REST (1317) are surfaced only on the deployment-scoped `-internal` aggregate Service. From a recent SND's `.status`:
```yaml
internalService:
name: bench-major-upgrade-X-internal
ports:
evmHttp: 8545
rest: 1317
rpc: 26657
perPodServices:
ports:
evmHttp: 8545
evmWs: 8546 # no 26657, no 1317
endpoints:
tendermintRpc: http://bench-major-upgrade-X-internal.nightly.svc:26657
tendermintRest: http://bench-major-upgrade-X-internal.nightly.svc:1317
```
Fix
Three sed substitutions in `scenarios/major-upgrade.yaml`:
TM RPC/REST are stateless query endpoints so the aggregate (any healthy validator backing the Service) is the right target.
Symptom chain on the live run
Single fix at the source resolves the whole cascade.
Bug count
Fix #8 in the major-upgrade-runs-end-to-end debugging chain. Same shape as several earlier ones: an assumption about the wider system that doesn't survive contact with the actual cluster. The audit's "trust but verify" principle continues to earn its keep.
🤖 Generated with Claude Code