Align LightBlockFromProto with its doc comment#3460
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3460 +/- ##
=======================================
Coverage 59.30% 59.31%
=======================================
Files 2127 2127
Lines 175876 175832 -44
=======================================
- Hits 104305 104294 -11
+ Misses 62473 62458 -15
+ Partials 9098 9080 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The doc comment for LightBlockFromProto promises an error when either the validator set or the signed header is invalid. The implementation, however, treated nil sub-fields as optional and returned a partially populated LightBlock. Honor the documented contract so callers can rely on err == nil meaning the returned LightBlock is fully populated. Also fix the "Lightblock" -> "LightBlock" typo in the same comment.
3f9b7c8 to
1b8b90e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1b8b90e. Configure here.
sei-will
approved these changes
May 18, 2026
wen-coding
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The doc comment for LightBlockFromProto promises an error when either the validator set or the signed header is invalid. The implementation, however, treated nil sub-fields as optional and returned a partially populated LightBlock. Honor the documented contract so callers can rely on err == nil meaning the returned LightBlock is fully populated.
Also fix the "Lightblock" -> "LightBlock" typo in the same comment.