Skip to content

fix(flatkv): correct catchup metrics #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blindchaser merged 1 commit into from
May 19, 2026
Merged

fix(flatkv): correct catchup metrics #3447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sei-db/state_db/sc/flatkv/store_catchup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,14 @@ func (s *CommitStore) catchup(targetVersion int64) (err error) {
// Replayed blocks are reported regardless of catchup outcome: even on a
// later error, the blocks that did replay are real progress that moved
// committedVersion forward.
//
// CurrentVersion is intentionally NOT recorded here: the write-mode
// callers (LoadVersion, Rollback) record it on success themselves, and
// recording it from catchup would pollute the gauge when openReadOnly
// invokes catchup during a read-only historical load.
defer func() {
if replayed > 0 {
otelMetrics.CatchupReplayNumBlocks.Add(s.ctx, int64(replayed))
otelMetrics.CurrentVersion.Record(s.ctx, s.committedVersion)
}
obs.done(&err, nil,
"startOffset", startOff,
Expand Down Expand Up @@ -204,6 +208,10 @@ func (s *CommitStore) catchup(targetVersion int64) (err error) {
s.committedVersion = entry.Version
s.committedLtHash = s.workingLtHash.Clone()
s.clearPendingWrites()
recordPendingWrites(s.ctx, accountDBDir, 0)
recordPendingWrites(s.ctx, codeDBDir, 0)
recordPendingWrites(s.ctx, storageDBDir, 0)
recordPendingWrites(s.ctx, legacyDBDir, 0)
expectedNext = entry.Version + 1

replayed++
Expand Down
Loading