feat(giga): don't fail if evmone can't load#3443
Conversation
PR SummaryMedium Risk Overview Test helpers ( Reviewed by Cursor Bugbot for commit aee3d65. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d863917. Configure here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3443 +/- ##
==========================================
- Coverage 59.30% 59.30% -0.01%
==========================================
Files 2127 2127
Lines 175877 175875 -2
==========================================
- Hits 104301 104299 -2
- Misses 62489 62490 +1
+ Partials 9087 9086 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| if err != nil { | ||
| panic(fmt.Sprintf("failed to load evmone: %s", err)) | ||
| // evmone is loaded best-effort | ||
| if evmoneVM, err := gigalib.InitEvmoneVM(); err == nil { |
There was a problem hiding this comment.
Is this only invoked once on startup? Can we add a log here showing the error and say we are switching to geth executor?
BTW, is there any chance that we can't load either the evmone or the geth executor?
There was a problem hiding this comment.
Yes, it's only invoked on startup. Even if it successfully loads, we never use it (because it hasn't been tested yet). We only ever use the Geth executor (see here).
I'm happy to add that as a debug log. I just don't want users to be confused and think something is wrong.
BTW, is there any chance that we can't load either the evmone or the geth executor?
No, there's no "loading" of the geth executor, since it's just native golang.

Describe your changes and provide context
This allows nodes on Ubuntu 22.04 or earlier to use Giga without having to install new deps.
Testing performed to validate your change
Tests pass.