Skip to content

feat(giga): don't fail if evmone can't load#3443

Open
arajasek wants to merge 2 commits into
mainfrom
asr/evmone
Open

feat(giga): don't fail if evmone can't load#3443
arajasek wants to merge 2 commits into
mainfrom
asr/evmone

Conversation

@arajasek
Copy link
Copy Markdown
Contributor

Describe your changes and provide context

This allows nodes on Ubuntu 22.04 or earlier to use Giga without having to install new deps.

Testing performed to validate your change

Tests pass.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 15, 2026

PR Summary

Medium Risk
When gigaExecutorConfig.Enabled is on, nodes will no longer hard-fail if gigalib.InitEvmoneVM() errors; this can change runtime execution/performance characteristics while still enabling the Giga path. The change is localized but touches EVM execution initialization and test setup behavior.

Overview
Giga executor no longer panics if evmone can’t be loaded. When Giga is enabled, InitEvmoneVM() is now attempted best-effort; on failure the node continues without setting GigaEvmKeeper.EvmoneVM and logs a debug message instead of panicking.

Test helpers (NewGigaTestWrapperWithRegularStore) were updated to mirror this best-effort initialization, avoiding test panics when evmone isn’t available.

Reviewed by Cursor Bugbot for commit aee3d65. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 19, 2026, 2:02 PM

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d863917. Configure here.

Comment thread app/app.go
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.30%. Comparing base (1b89b44) to head (aee3d65).

Files with missing lines Patch % Lines
app/app.go 0.00% 4 Missing ⚠️
app/test_helpers.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3443      +/-   ##
==========================================
- Coverage   59.30%   59.30%   -0.01%     
==========================================
  Files        2127     2127              
  Lines      175877   175875       -2     
==========================================
- Hits       104301   104299       -2     
- Misses      62489    62490       +1     
+ Partials     9087     9086       -1     
Flag Coverage Δ
sei-chain-pr 50.48% <0.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/test_helpers.go 72.07% <0.00%> (+0.21%) ⬆️
app/app.go 69.28% <0.00%> (-0.12%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread app/app.go
if err != nil {
panic(fmt.Sprintf("failed to load evmone: %s", err))
// evmone is loaded best-effort
if evmoneVM, err := gigalib.InitEvmoneVM(); err == nil {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only invoked once on startup? Can we add a log here showing the error and say we are switching to geth executor?

BTW, is there any chance that we can't load either the evmone or the geth executor?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's only invoked on startup. Even if it successfully loads, we never use it (because it hasn't been tested yet). We only ever use the Geth executor (see here).

I'm happy to add that as a debug log. I just don't want users to be confused and think something is wrong.

BTW, is there any chance that we can't load either the evmone or the geth executor?

No, there's no "loading" of the geth executor, since it's just native golang.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added debug log

@arajasek arajasek self-assigned this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants