Skip to content

ci: move onto the seidroid review workflow, retire ai-review - #81

Closed
bdchatham wants to merge 1 commit into
mainfrom
chore/remove-old-ai-review
Closed

bdchatham wants to merge 1 commit into
mainfrom
chore/remove-old-ai-review

Conversation

@bdchatham

Copy link
Copy Markdown

Summary

This PR replaces the old AI review with seidroid. That is the same move sei-chain (#4372), sei-load (#92), sei-internal-skills (#416) and platform (#1652) made.

  • Removed: .github/workflows/ai-review.yml, the caller of the old three-pass review in uci (ai-review.yml).

  • Added: .github/workflows/seidroid.yml. It calls uci seidroid-review.yml at v0.0.26 (0dc48cf) with the same triggers and jobs as sei-chain: review, close (anchored) and reclaim on close.

  • Why both cannot stay: uci says seidroid-review replaces ai-review. If both run, every PR gets two reviews. A comment with @seidroid review and more text also starts the old review path.

  • What stays: ai-assist.yml (the @seidroid assistant) and every other workflow.

  • Not set: approve-on-success. The repo owners can turn on bot approval on a clean review if they want it.

Before merge: a repo admin must add the repository secret OMNIGENT_MACHINE_CLIENT_SECRET (the seidroid machine credential, the same as in sei-chain). This repo does not have it, so without it every seidroid review fails. The GitHub App secrets PLATFORM_CODE_AGENT_APP_ID and PLATFORM_CODE_AGENT_APP_PK are already available.

How to use it

To ask for a review, post a comment whose whole body is @seidroid review. The assistant answers any other comment that mentions @seidroid.

Verification

  • actionlint passes on seidroid.yml.
  • No branch protection rule or ruleset on the default branch requires the AI Review check. seidroid also publishes an AI Review check run by default.

🤖 Generated with Claude Code

Replace the uci ai-review.yml caller with a seidroid.yml caller of uci
seidroid-review.yml at v0.0.26, the same wiring sei-chain uses. uci says
seidroid-review replaces ai-review and the two must not run side by side.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes how automated PR reviews run and which secrets must be configured; misconfiguration or missing OMNIGENT_MACHINE_CLIENT_SECRET will break reviews until fixed.

Overview
Replaces the legacy uci ai-review GitHub Action with the seidroid review workflow, aligning this repo with sei-chain and other org repos so PRs are not double-reviewed.

Removed .github/workflows/ai-review.yml, which reused uci ai-review.yml (v0.0.17) with broad PR/comment triggers and inherited secrets.

Added .github/workflows/seidroid.yml, which wires three reusable jobs to uci seidroid-review.yml at v0.0.26: automatic review on PR open/sync (excluding close), on-demand review when a comment/review body contains @seidroid review, anchored @seidroid review close on issue comments, and reclaim (close mode) when the PR is closed. Reviews are gated to sei-protocol/sei-core and pass explicit app/machine secrets (OMNIGENT_MACHINE_CLIENT_SECRET, platform code agent app id/key) instead of secrets: inherit.

Operational note: merges require the new OMNIGENT_MACHINE_CLIENT_SECRET repo secret; fork PRs cannot auto-reclaim sandboxes on close without a manual close comment.

Reviewed by Cursor Bugbot for commit 51fbabd. Bugbot is set up for automated code reviews on this repo. Configure here.

@bdchatham

Copy link
Copy Markdown
Author

Closing this: it is out of scope. We remove the old AI review only from the core packages that already run seidroid, and those have no ai-review.yml left. This repository does not run seidroid, so it keeps its current review.

@bdchatham bdchatham closed this Oct 1, 2026
@bdchatham
bdchatham deleted the chore/remove-old-ai-review branch October 1, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant