Skip to content

feat(settingsInterfaces.ts): setting to skip blocklist modal#3277

Open
ofgrenudo wants to merge 5 commits into
seerr-team:developfrom
ofgrenudo:feat-setting-to-skip-blocklist-modal-issue2916
Open

feat(settingsInterfaces.ts): setting to skip blocklist modal#3277
ofgrenudo wants to merge 5 commits into
seerr-team:developfrom
ofgrenudo:feat-setting-to-skip-blocklist-modal-issue2916

Conversation

@ofgrenudo

@ofgrenudo ofgrenudo commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

This PR extends the settings interface to account for a default behavior of auto adding content to the denylist. Once the settings interface was extended I account for the behavior of a present variable where it is true, and if true then we automatically add the content to the deny list. if it is false, we retain the modal that pops up by default.

How Has This Been Tested?

  • I have built it
  • tested behavior before on fresh branch
  • make code changes and test behavior with toggle set to false or off
  • test behavior with toggle set to true or on.
  • test behavior with toggle set to false again to retain that it continues to store state.

Screenshots / Logs (if applicable)

Video uploaded to google drive, too big to attach here.

https://drive.google.com/file/d/1xysfB8ys-bK-WoPY7i_atiNS51bPfWQ3/view

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract

AI Discolsure

AI was used to extend the settings interface, and all other places the new interface would be used.

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Added a “Skip Blocklist Confirmation” setting to bypass the blocklist modal.
    • Updated blocklist hide/add actions across item details to process immediately when enabled.
    • Added a tooltip explaining the new setting’s behavior.
  • Bug Fixes

    • Ensured the new preference is consistently available during settings initialization and before public settings finish loading.

…gs interace

addes skipBlocklistModal to relevant areas
…interface value skipBlocklistM

Accommodates behavior for interface value skipBlocklistModal essentially grabs value from settings
interface and if its true, it just auto adds to block list. if its false, it sets the block list
modal to pop up
…enylisting media

adds a few strings in the translation for auto denylisting media with a toggle button
@ofgrenudo
ofgrenudo requested a review from a team as a code owner July 21, 2026 17:48
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8ff65e4b-10bf-4686-8b24-011771aa0a49

📥 Commits

Reviewing files that changed from the base of the PR and between 8d5e25d and 69c26b8.

📒 Files selected for processing (1)
  • src/pages/_app.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/_app.tsx

📝 Walkthrough

Walkthrough

Adds a default-off skipBlocklistModal setting, exposes and persists it through public settings, and updates blocklist actions to bypass confirmation when enabled.

Changes

Blocklist confirmation setting

Layer / File(s) Summary
Settings contract and defaults
server/interfaces/api/settingsInterfaces.ts, server/lib/settings/index.ts, src/context/SettingsContext.tsx, src/pages/_app.tsx
Defines skipBlocklistModal, defaults it to false, exposes it in public settings, and includes it in client fallback settings.
Settings form persistence
src/components/Settings/SettingsMain/index.tsx, src/i18n/locale/en.json
Adds the checkbox, localized label and tooltip, Formik initialization, and save payload handling.
Conditional blocklist actions
src/components/CollectionDetails/index.tsx, src/components/MovieDetails/index.tsx, src/components/TvDetails/index.tsx, src/components/TitleCard/index.tsx
Directly invokes the blocklist action when enabled; otherwise opens the existing confirmation modal.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SettingsMain
  participant SettingsAPI
  participant SettingsContext
  participant BlocklistAction
  participant BlocklistModal

  SettingsMain->>SettingsAPI: Save skipBlocklistModal
  SettingsAPI->>SettingsContext: Provide public setting
  BlocklistAction->>SettingsContext: Read skipBlocklistModal
  alt Enabled
    BlocklistAction->>BlocklistAction: Invoke onClickHideItemBtn
  else Disabled
    BlocklistAction->>BlocklistModal: Open confirmation modal
  end
Loading

Possibly related PRs

Suggested reviewers: gauthier-th, fallenbagel

Poem

A bunny flips the setting with care,
No modal may spring from the lair.
One click blocks the show,
Or asks before go—
A tidy new toggle to share!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a setting to skip the blocklist modal.
Linked Issues check ✅ Passed The PR adds a default-off skip-blocklist setting and updates the action flow to bypass the modal, matching issue #2916's main requirement.
Out of Scope Changes check ✅ Passed The changes stay within the blocklist-confirmation setting scope and related settings/UI updates, with no obvious unrelated additions.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ofgrenudo ofgrenudo changed the title Feat setting to skip blocklist modal issue2916 feat(settingsInterfaces.ts): setting to skip blocklist modal Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add setting to skip blocklist confirmation dialog

1 participant