Conversation
Adds helm settings for:
* `dnsConfig`
* `dnsPolicy`
* `hostUsers`
* `priorityClassName`
Fixes #2663
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Helm chart version is bumped to 3.8.0. New values configure pod DNS behavior, host user namespaces, and priority classes, with corresponding conditional StatefulSet fields. The README documents these settings. ChangesHelm pod configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/seerr-chart/README.md`:
- Line 104: Correct the Values table in the README: restore the service row’s
description to document service configuration, and add separate entries for the
hostUsers and priorityClassName pod settings using their corresponding defaults
and descriptions from the chart values.
In `@charts/seerr-chart/templates/statefulset.yaml`:
- Around line 34-36: Gate the hostUsers field in the StatefulSet template using
the Kubernetes version, rendering it only for clusters where spec.hostUsers is
supported (Kubernetes 1.25 or newer). Preserve the existing boolean check and
omit the field on supported 1.23/1.24 clusters; use the chart’s existing
version-gating conventions if available.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0623240b-797f-4b6e-9e94-26b5a84efe8a
📒 Files selected for processing (4)
charts/seerr-chart/Chart.yamlcharts/seerr-chart/README.mdcharts/seerr-chart/templates/statefulset.yamlcharts/seerr-chart/values.yaml
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
Description
How Has This Been Tested?
local
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit