Skip to content

chore(helm): add dnsConfig and dnsPolicy#3254

Open
M0NsTeRRR wants to merge 3 commits into
developfrom
pr-2733
Open

chore(helm): add dnsConfig and dnsPolicy#3254
M0NsTeRRR wants to merge 3 commits into
developfrom
pr-2733

Conversation

@M0NsTeRRR

@M0NsTeRRR M0NsTeRRR commented Jul 18, 2026

Copy link
Copy Markdown
Member

Description

How Has This Been Tested?

local

Screenshots / Logs (if applicable)

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Summary by CodeRabbit

  • New Features
    • Added Helm chart values to configure pod DNS policy and custom DNS settings.
    • Added options to set pod priority class and control pod host user behavior.
  • Documentation
    • Updated Helm chart README to reflect version 3.8.0 and the new configuration options.

especially-relative and others added 2 commits July 18, 2026 17:04
    Adds helm settings for:
    
    * `dnsConfig`
    * `dnsPolicy`
    * `hostUsers`
    * `priorityClassName`
    
    Fixes #2663
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
@M0NsTeRRR
M0NsTeRRR requested a review from a team as a code owner July 18, 2026 16:17
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ad2cbba5-a0dc-4a21-8d73-b1c394a2ce39

📥 Commits

Reviewing files that changed from the base of the PR and between aa4a626 and 4833bd7.

📒 Files selected for processing (2)
  • charts/seerr-chart/README.md
  • charts/seerr-chart/values.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • charts/seerr-chart/values.yaml

📝 Walkthrough

Walkthrough

The Helm chart version is bumped to 3.8.0. New values configure pod DNS behavior, host user namespaces, and priority classes, with corresponding conditional StatefulSet fields. The README documents these settings.

Changes

Helm pod configuration

Layer / File(s) Summary
Pod settings and StatefulSet rendering
charts/seerr-chart/values.yaml, charts/seerr-chart/templates/statefulset.yaml
Adds dnsPolicy, dnsConfig, hostUsers, and priorityClassName values and conditionally renders them in the pod specification.
Chart metadata and documentation
charts/seerr-chart/Chart.yaml, charts/seerr-chart/README.md
Bumps the chart version to 3.8.0 and documents the new DNS and priority class settings.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: 0xsysr3ll, fallenbagel

Poem

I’m a rabbit with DNS in my hat,
Setting priorities, fancy like that.
Stateful pods hop into line,
With chart version 3.8.0 shining fine.
A tidy Helm update is here!

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR also adds hostUsers and priorityClassName, which are not part of the linked dnsConfig/dnsPolicy request. Remove or justify the extra pod-spec additions, or split them into a separate PR focused on dnsConfig and dnsPolicy.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: adding dnsConfig and dnsPolicy support to the Helm chart.
Linked Issues check ✅ Passed The chart adds pod-level dnsConfig and dnsPolicy support as requested, including the documented ndots configuration use case.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@charts/seerr-chart/README.md`:
- Line 104: Correct the Values table in the README: restore the service row’s
description to document service configuration, and add separate entries for the
hostUsers and priorityClassName pod settings using their corresponding defaults
and descriptions from the chart values.

In `@charts/seerr-chart/templates/statefulset.yaml`:
- Around line 34-36: Gate the hostUsers field in the StatefulSet template using
the Kubernetes version, rendering it only for clusters where spec.hostUsers is
supported (Kubernetes 1.25 or newer). Preserve the existing boolean check and
omit the field on supported 1.23/1.24 clusters; use the chart’s existing
version-gating conventions if available.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0623240b-797f-4b6e-9e94-26b5a84efe8a

📥 Commits

Reviewing files that changed from the base of the PR and between 5ae70d0 and aa4a626.

📒 Files selected for processing (4)
  • charts/seerr-chart/Chart.yaml
  • charts/seerr-chart/README.md
  • charts/seerr-chart/templates/statefulset.yaml
  • charts/seerr-chart/values.yaml

Comment thread charts/seerr-chart/README.md Outdated
Comment thread charts/seerr-chart/templates/statefulset.yaml
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart: add dnsConfig template

2 participants