Skip to content

tools/nacp: add Polish to the game languages - #2929

Open
siano wants to merge 1 commit into
seedds:mainfrom
siano:add-polish-language
Open

siano wants to merge 1 commit into
seedds:mainfrom
siano:add-polish-language

Conversation

@siano

@siano siano commented Nov 17, 2026

Copy link
Copy Markdown

What and why

The Game language row and --language could not ask for Polish. Switch 2 titles such as The Legend of Zelda: Ocarina of Time (0400486024DEC000) ship Polish, which none of the 16 languages in dm/tools/nacp.py covers. A game packed from a NUP has no control data, so its row offers every language in the list, and Polish was not among them.

Polish (pl) is added to nacp.LANGUAGES as one more language. It gets no special handling. Because it is the 17th entry, the NACP reader takes it from bit 16 of SupportedLanguageFlag; I could not check that bit against a Switch 2 NACP that lists Polish (open). Switch 1 NACPs have it clear, so no existing game changes.

Checked

  • Tests: dm.tools.tests.test_launcher_settings, test_settings and test_docs pass. test_launcher_settings compares the offered options with all of nacp.LANGUAGES, so Polish is covered like the other languages.
  • Games run: Ocarina of Time v1.1.1, Mac app. Polish chosen in the launcher, and the game plays in Polish.
  • Devices and OS: M2 Max, macOS.
  • Not touched: the shader chain, the host, and tools every game uses, so no regress.py run.

Front ends

None. The list reaches front ends through launcher.json.

Docs

  • The finding is in the game's note, Game language. No reference entry: this is not a general mechanism
  • No chain tool changed
  • No game files, keys or data extracted from a game in the change or the attachments

@github-actions github-actions Bot added tools Tools and scripts (dm/tools, scripts) docs Documentation game: 0400486024DEC000 A game labels Nov 17, 2026
@siano
siano force-pushed the add-polish-language branch from bf469da to a5706a9 Compare November 17, 2026 12:20
The Game language row and --language could not ask for Polish. Switch 2 titles such as
Ocarina of Time ship Polish, which none of the 16 languages in nacp.py covers, and a game
packed from a NUP has no control data, so its row offers every language in that list.

Polish ('pl') is added to the list as one more language. As the 17th entry it is read from
bit 16 of SupportedLanguageFlag; that bit is not checked against a Switch 2 NACP (open).

Checked: test_launcher_settings, test_settings and test_docs pass. Ocarina of Time v1.1.1 on
an M2 Max Mac: Polish chosen in the launcher, the game plays in Polish. Noted in the game's
README.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@siano
siano force-pushed the add-polish-language branch from a5706a9 to fca784a Compare November 17, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation game: 0400486024DEC000 A game tools Tools and scripts (dm/tools, scripts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant