Repository navigation
Conversation
siano
force-pushed
the
add-polish-language
branch
from
November 17, 2026 12:20
bf469da to
a5706a9
Compare
The Game language row and --language could not ask for Polish. Switch 2 titles such as
Ocarina of Time ship Polish, which none of the 16 languages in nacp.py covers, and a game
packed from a NUP has no control data, so its row offers every language in that list.
Polish ('pl') is added to the list as one more language. As the 17th entry it is read from
bit 16 of SupportedLanguageFlag; that bit is not checked against a Switch 2 NACP (open).
Checked: test_launcher_settings, test_settings and test_docs pass. Ocarina of Time v1.1.1 on
an M2 Max Mac: Polish chosen in the launcher, the game plays in Polish. Noted in the game's
README.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
siano
force-pushed
the
add-polish-language
branch
from
November 17, 2026 12:40
a5706a9 to
fca784a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Game language row and
--languagecould not ask for Polish. Switch 2 titles such as The Legend of Zelda: Ocarina of Time (0400486024DEC000) ship Polish, which none of the 16 languages indm/tools/nacp.pycovers. A game packed from a NUP has no control data, so its row offers every language in the list, and Polish was not among them.Polish (
pl) is added tonacp.LANGUAGESas one more language. It gets no special handling. Because it is the 17th entry, the NACP reader takes it from bit 16 ofSupportedLanguageFlag; I could not check that bit against a Switch 2 NACP that lists Polish (open). Switch 1 NACPs have it clear, so no existing game changes.Checked
dm.tools.tests.test_launcher_settings,test_settingsandtest_docspass.test_launcher_settingscompares the offered options with all ofnacp.LANGUAGES, so Polish is covered like the other languages.regress.pyrun.Front ends
None. The list reaches front ends through
launcher.json.Docs