[pull] master from apache:master - #1419
Merged
Merged
Conversation
* [FLINK-40282][docs] Expand and correct the concepts Glossary * [FLINK-40282][docs] Expand and correct Glossary: Addressed PR comments * [FLINK-40282][docs] Removed incorrect sentences identified by Claude. Fixed stale inbound link from Flink Architecture page. * [FLINK-40282][docs] Addressing PR comments: 1) added definition of Key Group; 2) Reworded and expanded the statement about Transformations mapping to Operators. Also added newlines to break accidentally long lines (to keep consistency across the doc) * [FLINK-40383][docs] Clarified maxParallelism * [FLINK-40383][docs] Addressed comments. Added links to Flink Architecture. Fixed minor typos * [FLINK-40383][docs] Add link to Region Failover Strategy * [FLINK-40383][docs] Addressed PR comments
…y abort between fetch and drain Spill files produced by readInputData were only deleted once drain() ran, so any abort between fetch and drain leaked them until TaskManager shutdown. - readInputData deletes the handler's spill directory if it fails before handing the state off. This does not depend on the produced FetchedChannelState having been built, since stateHandler.close() itself may be what failed. - fetchChannelState registers the fetched state with the task's resourceCloser, so cleanUp() deletes the spill files whenever recovery aborts afterwards (drainer never built, mailbox mail rejected or dropped, drain() never scheduled). close() is idempotent, so a completed drain makes this a no-op; a fetch that finishes after cleanUp() is closed by the registry on the spot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )