refactor: isolate app and OS execution#134
Draft
adamcohenhillel wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PhoneToolGatewaycontract between Assistant features and phone-specific execution.android.openphoneAPI access behind theOpenPhoneOsToolGatewayadapter at the Assistant composition roots.scripts/check.sh.Why
The OS services already owned privileged execution, but portable Assistant packages still imported hidden OpenPhone framework APIs and the concrete framework executor. That made the app/runtime boundary implicit and easy to erode. This PR creates one explicit seam without changing execution policy or moving authority out of
system_server.Impact
Validation
./scripts/check.shgit diff --checkOpenPhoneAssistantfrom commit59ba9f6585febec32c62eed423614d41b1a7dfe9173/0.1.137-dev./scripts/verify-tegu-device.shopenphone_agent, Assistant, and SystemUI are alive; runtime status reportsphone_platform: openphone_os; no Assistant/SystemUI crash entriesStack
This draft PR is intentionally based on
chore/ai-home-plan/ #133 so the boundary refactor stays separate from the AI Home implementation. Retarget it tomainafter #133 merges.Full trajectory evaluation was not run because no model API key is configured locally; the no-key device and runtime smokes passed.