#1841 Fix leap command - #6209
Merged
Merged
Conversation
akleshchev
requested review from
maxim-productengine
and
a lite review from Copilot
August 27, 2026 16:35
maxim-productengine
approved these changes
Aug 27, 2026
akleshchev
force-pushed
the
andreyk/viewer_1814_2
branch
from
August 27, 2026 16:38
bd59a9b to
43dd618
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts command-line parsing for settings of type TYPE_LLSD so --leap / LeapCommand works when QA passes a plain path string (not LLSD notation), aligning runtime behavior with how LeapCommand is used elsewhere in the viewer.
Changes:
- Adds a fallback for
TYPE_LLSDcontrols: trysetValueFromNotation(), and if parsing fails, store the raw string as anLLSD::String. - Introduces an explanatory comment documenting why
LeapCommandmay not be LLSD notation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
--leap is mapped to --set LeapCommand
akleshchev
force-pushed
the
andreyk/viewer_1814_2
branch
from
August 27, 2026 18:08
5cc208a to
74d34a9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Suppressed comments (2)
indra/newview/llviewerwindow.cpp:3196
- Typo/grammar in the log message: "an it returned" should be "and it returned" (helps searchability and professionalism in logs).
LL_DEBUGS("Window") << "LLViewerWindow::handleKey - in 'traverse up' - no loops seen... just called keyboard_focus->handleKey an it returned false" << LL_ENDL;
indra/newview/llcommandlineparser.cpp:618
- Spelling/grammar in this new comment: "generaly" -> "generally" and "an TYPE_LLSD" -> "a TYPE_LLSD".
// Note that LeapCommand is an TYPE_LLSD, but generaly is not a notation string,
// so keep a fallback to saving value directly.
And improved relevant logging.
akleshchev
force-pushed
the
andreyk/viewer_1814_2
branch
from
August 27, 2026 18:12
74d34a9 to
3fd6d74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--leap is mapped to --set LeapCommand, but a path gets passed by QA, not an LLSD