#6206 Fix LLImageJ2CKDU shutdown order - #6207
Merged
Merged
Conversation
akleshchev
requested review from
maxim-productengine
and
a lite review from Copilot
August 26, 2026 20:47
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the destruction order of Kakadu (KDU) decode-related objects in LLImageJ2CKDU::cleanupCodeStream() to prevent an occasional shutdown/cleanup crash by ensuring dependent objects are torn down before the objects they reference.
Changes:
- Reset
mDecodeStatebeforemCodeStreamp, sinceLLKDUDecodeStateis constructed withmCodeStreamp.get()and may retain/use that pointer during destruction. - Reset
mCodeStreampbeforemInputp, since the codestream is created frommInputp(mCodeStreamp->create(mInputp.get())) and may rely on it during teardown.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
maxim-productengine
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for an ocational KDU cleanup crash.