Skip to content

ROCK-9041 Dispose ContentStream in AzureBlobStorage.SaveContent #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stphnlee wants to merge 1 commit into from
Closed

ROCK-9041 Dispose ContentStream in AzureBlobStorage.SaveContent #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions Rock/Storage/Provider/AzureBlobStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,23 @@ The exception was being thrown by the second call to BlobClient.Upload() when re
Reason: Wide SMS image attachments stored in Azure cause exceptions in Communication Wizard.
https://github.com/SparkDevNetwork/Rock/issues/5719
*/
blobClient.Upload( binaryFile.ContentStream, overwrite: true );
/*
9/28/2026 - SL (SECC)

fileSize = binaryFile.ContentStream.Length;
Dispose the content stream after uploading so this provider follows the same
contract as the Database and FileSystem providers. Callers such as
SignatureDocumentTemplateService.UpdateDocumentStatus assign a FileStream to
ContentStream, save, then File.Delete() the temp file; leaving the stream open
leaked the file handle and caused the delete to throw IOException.

Reason: ROCK-9041 Process Signature Documents job fails with file lock on Azure provider.
*/
using ( var stream = binaryFile.ContentStream )
{
blobClient.Upload( stream, overwrite: true );

fileSize = stream.Length;
}
}

/// <summary>
Expand Down
Loading