Skip to content

fix: align npm trusted publishing workflow name#123

Merged
swernerx merged 1 commit into
mainfrom
codex/rename-publish-workflow
Jul 22, 2026
Merged

fix: align npm trusted publishing workflow name#123
swernerx merged 1 commit into
mainfrom
codex/rename-publish-workflow

Conversation

@swernerx

Copy link
Copy Markdown
Member

What changed

  • Rename .github/workflows/release-please.yml to .github/workflows/publish.yml.
  • Update the release documentation to reference the workflow filename used by npm Trusted Publishing.

Why

npm Trusted Publishing is configured for publish.yml. The previous filename caused the OIDC token exchange to fail, so the package publish never reached npm.

Validation

  • pnpm format:check
  • pnpm lint
  • pnpm typecheck
  • pnpm test:run — 51 files, 652 tests passed
  • pnpm build

Refs #92

@swernerx
swernerx marked this pull request as ready for review July 22, 2026 21:40
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.81%. Comparing base (9e4368d) to head (a696ef9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   47.81%   47.81%           
=======================================
  Files          50       50           
  Lines        5733     5733           
  Branches     1713     1671   -42     
=======================================
  Hits         2741     2741           
  Misses       2990     2990           
  Partials        2        2           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR aligns the release workflow path with npm Trusted Publishing. The main changes are:

  • Renames release-please.yml to publish.yml without changing its contents.
  • Updates the release documentation to reference publish.yml.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • No repository-local references still use the old workflow path.
  • The workflow contents and release behavior remain unchanged.

Important Files Changed

Filename Overview
.github/workflows/publish.yml Renames the existing release workflow while preserving its triggers, permissions, jobs, and display name.
README.md Updates the npm Trusted Publishing guidance to use the new workflow filename.

Reviews (1): Last reviewed commit: "fix: align npm trusted publishing workfl..." | Re-trigger Greptile

@swernerx
swernerx merged commit 1568b82 into main Jul 22, 2026
10 checks passed
@swernerx
swernerx deleted the codex/rename-publish-workflow branch July 22, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant