fix(seal-tui): drop zed from modern-terminal allowlist (SEA-782)#503
fix(seal-tui): drop zed from modern-terminal allowlist (SEA-782)#503mattwilkinsonn wants to merge 2 commits into
Conversation
Zed's terminal pane is built on `alacritty_terminal`, which doesn't implement the kitty keyboard protocol, so cmd+c never arrives as `SUPER+c` — classifying Zed as modern disabled copy-on-select and left selections uncopyable. Co-Authored-By: seal <noreply@sealedsecurity.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughZed is removed from the modern-terminal allowlist so ChangesZed Terminal Detection Exclusion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Greptile SummaryThis PR removes Zed from the
Confidence Score: 5/5Safe to merge — the change correctly removes Zed from the modern-terminal allowlist, restoring copy-on-select for Zed users whose cmd+c never reached the TUI. The change is a one-entry constant removal backed by a clear technical rationale (alacritty_terminal lacks kitty keyboard protocol support) and by two new tests: one that pins the negative-match behavior for Zed, and one that regression-locks every remaining allowlist entry. No logic paths are altered beyond the constant. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[detect_terminal_capability] --> B{probe_xtversion}
B -- "Known name in MODERN_NAMES\ne.g. ghostty, kitty, wezterm..." --> C[TerminalCapability::Modern\nsource: Xtversion]
B -- "No response / unknown name" --> D{probe_term_program\nTERM_PROGRAM env var}
D -- "Name in MODERN_NAMES\ne.g. iterm.app, foot..." --> E[TerminalCapability::Modern\nsource: TermProgram]
D -- "Not in list\ne.g. zed, vscode" --> F[None → Unknown]
F --> G[TerminalCapability::Unknown\ncopy-on-select path]
C --> H[cmd+c hint\ncopy-on-select OFF]
E --> H
G --> I[ctrl+y / auto-copy hint\ncopy-on-select ON]
Reviews (2): Last reviewed commit: "docs(seal-utils): drop Zed from TERM_PRO..." | Re-trigger Greptile |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/seal-tui/src/terminal_cap.rs`:
- Around line 58-63: Update the documentation in the env.rs TERM_PROGRAM
examples to remove "Zed" from the list of modern-terminal examples so it matches
the exclusion described in terminal_cap.rs; locate the TERM_PROGRAM
examples/docstring (the doc comment or constant that lists modern terminals in
crates::seal_utils::env or the function that documents TERM_PROGRAM usage) and
change the examples and explanatory text to explicitly exclude Zed and mirror
the wording used in terminal_cap.rs about Zed relying on alacritty_terminal and
not implementing the kitty keyboard protocol.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fb095165-d14a-4793-8cd8-e0f22d6fc024
📒 Files selected for processing (2)
crates/seal-tui/src/chat/runloop.rscrates/seal-tui/src/terminal_cap.rs
… (SEA-782) Co-Authored-By: seal <noreply@sealedsecurity.com>
Merge activity
|
1 participant
Pull request
Summary
Related issues
Changes
Test plan
Screenshots
Notes for reviewers
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.