build(deps): bump wasmtime-wasi from 44.0.2 to 45.0.1#362
build(deps): bump wasmtime-wasi from 44.0.2 to 45.0.1#362dependabot[bot] wants to merge 1 commit into
Conversation
1c756f6 to
9c9da5a
Compare
|
|
5dda320 to
03bfcdc
Compare
Greptile SummaryThis dependabot PR bumps
Confidence Score: 3/5Not safe to merge as-is: the The Cargo.toml — the Important Files Changed
Reviews (5): Last reviewed commit: "build(deps): bump wasmtime-wasi from 44...." | Re-trigger Greptile |
| # same wasm hash returns in ~tens of ms. SEA-378. | ||
| "cache", | ||
| ] } | ||
| wasmtime-wasi = { version = "44", features = ["p3"] } | ||
| wasmtime-wasi = { version = "45", features = ["p3"] } | ||
| wit-bindgen = { version = "0.55", default-features = false, features = [ | ||
| "macros", |
There was a problem hiding this comment.
Version mismatch between
wasmtime and wasmtime-wasi
wasmtime is still pinned to "44" while wasmtime-wasi is bumped to "45". The Cargo.lock confirms both wasmtime 44.0.2 and wasmtime 45.0.0 are now present in the graph simultaneously. Because Rust treats them as entirely separate crates, any API boundary where the workspace passes a wasmtime 44 type (Store, Linker, Engine, etc.) into a wasmtime-wasi 45 function — which expects the corresponding wasmtime 45 types — will produce a compile-time type error. The wasmtime pin in Cargo.toml must be bumped to "45" together with wasmtime-wasi.
| # same wasm hash returns in ~tens of ms. SEA-378. | |
| "cache", | |
| ] } | |
| wasmtime-wasi = { version = "44", features = ["p3"] } | |
| wasmtime-wasi = { version = "45", features = ["p3"] } | |
| wit-bindgen = { version = "0.55", default-features = false, features = [ | |
| "macros", | |
| wasmtime = { version = "45", features = [ |
03bfcdc to
eb1da51
Compare
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
eb1da51 to
3e54459
Compare
3e54459 to
22e64b1
Compare
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates the workspace dependency ChangesDependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Cargo.toml`:
- Line 23: The workspace is pinning mismatched wasmtime versions: update the
wasmtime dependency in Cargo.toml from version 44 to 45 so it matches
wasmtime-wasi = { version = "45", features = ["p3"] }; ensure the wasmtime crate
entry (the one currently at 44) is bumped to 45 to avoid duplicate wasmtime
versions that break type compatibility (e.g., wasmtime::component::Linker used
with wasmtime_wasi::p3::add_to_linker), then run cargo update / regenerate
Cargo.lock to ensure a single wasmtime 45.x is used across crates (including
crates/seal-runtime).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 50a6358f-ea44-4f20-880a-3313d4e8aff5
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
Bumps [wasmtime-wasi](https://github.com/bytecodealliance/wasmtime) from 44.0.2 to 45.0.1. - [Release notes](https://github.com/bytecodealliance/wasmtime/releases) - [Changelog](https://github.com/bytecodealliance/wasmtime/blob/v45.0.1/RELEASES.md) - [Commits](bytecodealliance/wasmtime@v44.0.2...v45.0.1) --- updated-dependencies: - dependency-name: wasmtime-wasi dependency-version: 45.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
22e64b1 to
83f15d8
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
Cargo.toml (1)
23-23:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winVersion skew:
wasmtime-wasi45 requireswasmtime45 (still unresolved).This change bumps
wasmtime-wasito version 45, butwasmtimeremains pinned at version 44 on line 14. As noted in the previous review,wasmtime-wasi 45.0.1depends onwasmtime 45.0.1, which will introduce bothwasmtime44.x and 45.x into the dependency graph. Types likewasmtime::component::Linker(used incrates/seal-runtime/src/engine/runtime.rswithwasmtime_wasi::p3::add_to_linker) must originate from the samewasmtimeversion to avoid compilation failure or broken type contracts.Line 14 must be updated to
wasmtime = { version = "45", ... }in this same PR.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Cargo.toml` at line 23, Update Cargo.toml to keep wasmtime and wasmtime-wasi versions in sync: change the wasmtime dependency (currently pinned to 44) to version "45" so wasmtime = { version = "45", ... } matches wasmtime-wasi = { version = "45", features = ["p3"] }; this avoids mixed versions and the resulting type mismatch for types like wasmtime::component::Linker used alongside wasmtime_wasi::p3::add_to_linker (see crates/seal-runtime/src/engine/runtime.rs) — ensure any feature flags or optional fields on the wasmtime entry are preserved when bumping the version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@Cargo.toml`:
- Line 23: Update Cargo.toml to keep wasmtime and wasmtime-wasi versions in
sync: change the wasmtime dependency (currently pinned to 44) to version "45" so
wasmtime = { version = "45", ... } matches wasmtime-wasi = { version = "45",
features = ["p3"] }; this avoids mixed versions and the resulting type mismatch
for types like wasmtime::component::Linker used alongside
wasmtime_wasi::p3::add_to_linker (see crates/seal-runtime/src/engine/runtime.rs)
— ensure any feature flags or optional fields on the wasmtime entry are
preserved when bumping the version.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c45f583d-0a5a-4e9b-b53c-4cfbe8902ff9
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
|
Superseded by #539. |
Bumps wasmtime-wasi from 44.0.2 to 45.0.1.
Release notes
Sourced from wasmtime-wasi's releases.
... (truncated)
Changelog
Sourced from wasmtime-wasi's changelog.
... (truncated)
Commits
83166baRelease Wasmtime 45.0.1 (#13567)83371d9Suggesting v45.0.1 cherry-pick for zero-delay timers (#13559)377cd91Release Wasmtime 45.0.0 (#13416)1eb2c19release-45.0.0: Fix wasmtime-wasi path_open(TRUNCATE) bypass of FilePerms::WR...49b2aa8Add release notes (#13328)52e14e8Fix the version bump workflow (#13275)8bdb373gc_fuzz: Struct fields (#13101)e3e5aa6Refactor how inlining is configured in Wasmtime (#13250)85ae784Fix slow WASI stdin reads by passing size hint to worker thread (#13256)57ed7dbs390x: correct off-by-one error in rotate then select insts (#13262)Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.