tool: a VM on x86-64 cannot have scheduling params#552
Merged
Conversation
dreamliner787-9
force-pushed
the
manual_update
branch
from
1a7c024 to
3ebadd2
Compare
Because the tool will default to priority 0 if it is not specified. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
No behavioural changes. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
This is because on x86-64, the VM shares TCB with the parent PD (VMM). Rather than being distinct entities like on ARM. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
Add tests for valid and invalid VM scenarios. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
dreamliner787-9
force-pushed
the
manual_update
branch
from
3ebadd2 to
58b2eab
Compare
| pub priority: u8, | ||
| pub budget: u64, | ||
| pub period: u64, | ||
| pub sched_params: SchedulingParams, |
Collaborator
There was a problem hiding this comment.
This change to PD isn't actually necessary, right? This is what creates a bunch of changes everywhere else.
Collaborator
Author
There was a problem hiding this comment.
That's right, I made that change because in struct VirtualMachine I thought making the priority, budget and period Optional is a bit ugly. So I applied the refactor to ProtectionDomain too.
midnightveil
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #540.