seL4GlobalAsynch: add missing header#54
Merged
Merged
Conversation
The `*_emit_underlying` functions were previously not declared in any header, but can used in user code (e.g. in crossvm_init.c in vm-examples). This previously worked, because earlier versions of gcc allowed implicit function declarations. Add the missing header for seL4GlobalAsynch and declare the function there. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Member
Author
|
(will add the usual style fix after review) |
Probably the main problem is that the code is compiled without warnings or not enough warnings enabled. Compilers would warn about stuff like this for decades. |
Indanz
approved these changes
Jun 11, 2026
|
I guess no one has been using this for years. Why not just remove it instead? |
Member
Author
This one is actually used, it’s just that the implicit declaration happened to work and people either ignored the warning or didn’t have it enabled. The usb one in the other PR is unused afaict, but it was easier to update it than to try to untangle all that driver code. |
Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
*_emit_underlyingfunctions were previously not declared in any header, but can used in user code (e.g. in crossvm_init.c in vm-examples). This previously worked, because earlier versions of gcc allowed implicit function declarations.Add the missing header for seL4GlobalAsynch and declare the function there.
Together with seL4/projects_libs#26 and seL4/camkes-vm-examples#98, this should now fix the CAmkES vm-examples build for armv7.
Test with: seL4/projects_libs#26 and seL4/camkes-vm-examples#98