fix: clear error when aggregating by labels without instances - #1264
Open
FarisHrvat wants to merge 1 commit into
Open
FarisHrvat wants to merge 1 commit into
FarisHrvat wants to merge 1 commit into
Conversation
aggregate(values=image, by=labels) with labels that are only background failed later in TableModel.parse with 'Regions in the AnnData object and region do not match', which says nothing about the actual cause. Fixes scverse#1250
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
=======================================
Coverage 91.40% 91.41%
=======================================
Files 53 53
Lines 8381 8383 +2
=======================================
+ Hits 7661 7663 +2
Misses 720 720
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1250
Aggregating an image by labels that are all background failed later in
TableModel.parsewith "Regions in the AnnData object andregiondo not match". Now it raises "No labelled instances (non-zero label ids) found inby". An error rather than an empty table, since 0-row tables don't validate yet (#1096).