Conversation
…601) The channels_as_legend block was only reached by the multi-channel else branch. The single-channel path now collects a legend entry using the channel color sampled from the cmap at 0.75. The RGB early-return path emits a warning since per-channel colors are not meaningful there. Sequential single-channel renders (e.g. DAPI then GFP) are fixed for free: each call appends its entry to channel_legend_entries.
… and visual tests for single-channel channels_as_legend
timtreis
changed the title
…gend visual tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 76.39% 76.41% +0.01%
==========================================
Files 11 11
Lines 3237 3239 +2
Branches 759 761 +2
==========================================
+ Hits 2473 2475 +2
Misses 466 466
Partials 298 298
🚀 New features to boost your workflow:
|
…pacity; add colorbar suppression test
…gend visual tests
…redundant comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
channels_as_legend=Truewas only applied in the multi-channel composite code path; single-channel renders and sequential multi-render workflows silently produced no legendcmap(0.75)— the same representative point used for the colorbarchannels_as_legendis not supported and is ignored, rather than silently doing nothingCloses #601