Skip to content

Make Settings attributes warn on *assign*, not on *access* (or reset) #89

Description

@flying-sheep

Description of feature

Settings get read internally and assigning them is the user facing API.

Therefore pydantic’s behavior of warning on access (which is also triggered by reset btw.) but not on assignment doesn’t fit and we should change that.

This tripped up @ilan-gold and me in scverse/anndata#2643

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions