fix: lint through hatch - #540
Open
flying-sheep wants to merge 5 commits into
Open
Conversation
|
A PR has been generated to the instance repo: scverse/cookiecutter-scverse-instance#304
You can check out the PR to preview your changes in an instance of the cookiecutter template. |
flying-sheep
commented
Jul 24, 2026
Comment on lines
-56
to
+57
| prek run --verbose --color=always --show-diff-on-failure --all-files | ||
| hatch check fmt --fix -- --verbose --color=always --show-diff-on-failure | ||
| hatch check code --fix -- --verbose --color=always --show-diff-on-failure | ||
| hatch check types -- --color=always |
Member
Author
There was a problem hiding this comment.
this should probably be reverted except for the “actually typecheck in CI” part
Member
Author
Zethson
approved these changes
Jul 30, 2026
Zethson
left a comment
Zethson
left a comment
Member
There was a problem hiding this comment.
Thanks for the .venv catch!
I love the added groups & the clarification around where to add type stubs. We could already add the pandas one maybe as an example?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: check what
hatch fmt --checkdoes with the missing scripts.Fixes #539