Repository navigation
fork-ci release: carry the files the heavy and desk kit installers read, and test every kit against the release - #920
Conversation
… release (desk: missing_sources) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ty rule, fleet desk scripts) heavy-install reads capacity-rule.json, capacity-format.json and capacity-vectors.json from packages/shared/src/capacity, and desk-install reads the fleet desk scripts, units and .github/fork-fleet.json; none were in the release paths, so both refused on every release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
lens: merge-path · reviewer: lens agent (Opus 5.5) · read at: 659ed69 |
|
lens: state · reviewer: lens agent (Opus 5.5) · read at: 659ed69 |
What
.github/fork-ci-release.jsonpathsnow also carries the files two kit installers read from outsidefork-kit/:packages/shared/src/capacity/capacity-rule.json,capacity-format.json,capacity-vectors.json(only these three, not the folder's README or readings file:heavy-installcopies exactly these)..github/scripts/fork-fleet-desk-agent.py,-desk-seed.py,-desk-wire.py,fork-fleet-hook.sh,fork-fleet-desk-agent.service,fork-fleet-refresh.service/.timer,fork-fleet-seed.service/.timerand.github/fork-fleet.json(the release's own fleet config, used when no--fleet-configis given)..github/scripts/fork-ci-release.test.py: it builds this commit's release file set withrelease_entries(exactly as the release does), writes those files to a folder, and runs each kit installer's own file check on it, with the installer loaded from that folder:read_sourceoversource_files()(agent-guards, cleaner, golive, schedule-kick),SOURCE_FILESthroughsource_file(heavy, model-guard),SOURCE_FILES(gh-apps),CODE(pc-agents), andmissing_sources(desk). A kit folder with an installer (sbin/) that has no row fails too, so a new kit cannot be skipped. One more check proves the test fails when the capacity files are left out.desk-install: the inline missing-file list is nowmissing_sources(source), whichinstalluses and the test calls (same behaviour).fork-kit/pc-agents/tests/setup.test.py: itsReleaseHoldstest (pc-agents only, checked the config paths by prefix) is removed; the new shared check covers pc-agents from the real release tree.fork-ci/README.mdand thefork-ci-release.pyheader say the release carries the files the kit installers read, and that the test enforces it.The review kit has no installer (used from a checkout), so it has no row.
Why
Since #786
heavy-installreads the capacity rule files frompackages/shared/src/capacity/, which no release held, so everyci/vNsince then (ci/v21 included) refuses at install:heavy-install: ... capacity/capacity-rule.json is missing. Checking every kit found the same gap in desk:desk-installrefuses any release because ten of its files were never released. The kits' own tests run from a full checkout, so neither gap showed in CI.Test
python3 .github/scripts/fork-ci-release.test.pyexits 1:all passed: 86 ok, 0 skipped.fork-kit/desk/tests/install.test.py: 58 tests OK.fork-kit/pc-agents/tests/setup.test.py: 60 tests OK.node .github/scripts/fork-seam-check.cjs --config-ref origin/main origin/main HEAD: exit 0.vp fmt --checkon the touched json/md: clean.State question
General vs project
General: the paths and the test are about the fork's own kits and release; no project, person or machine fact. The test discovers every kit folder with an installer, so a future kit (or a new file an installer reads) is covered without project config.
🤖 Generated with Claude Code