Skip to content
Merged
1 change: 1 addition & 0 deletions .github/fork-ci-tests.txt
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ fork-ci/actions/gradle-cache/gradle_cache.test.py
fork-ci/actions/handoff-put/handoff.test.py ~16s
fork-ci/actions/head-check/head_check.test.py ~69s
fork-ci/actions/head-check/head_gate.test.py
fork-ci/actions/head-check/review_guide.test.py
fork-ci/actions/job-changed/job-changed.test.py ~21s
fork-ci/actions/pinned/pinned.test.py
fork-ci/actions/pr-queue/lens.test.py
Expand Down
4 changes: 4 additions & 0 deletions .github/scripts/fork-contracts.test.py
Original file line number Diff line number Diff line change
Expand Up @@ -4171,6 +4171,10 @@ def result_step(jobs, name):
# Needs a checkout that is not a merge commit; CI's pull request checkout is one.
"fork-ci/actions/head-check/head_check.test.py": [
"SameChangeBare.test_a_checkout_that_is_not_a_merge_commit_is_refused"],
# Need the ci/vN tags; CI's checkout fetches none (only its Releases class runs there).
"fork-ci/actions/head-check/review_guide.test.py": ["ReleaseTags." + t for t in (
"test_override_authors_is_first_in_the_release_after_the_one_the_notes_name",
"test_the_path_rules_are_first_in_the_release_the_guide_names")],
}
check("records: the tests a part run may skip are exactly the pinned ones, each by name (MAY_SKIP)",
{f: sorted(n) if isinstance(n, list) else n for f, n in DECLARED_SKIPS.items()} == MAY_SKIP,
Expand Down
7 changes: 7 additions & 0 deletions fork-ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ Two habits every action expects:
To move to a new release, change the SHA and the comment together; read the new tag's release notes first
([RELEASE-NOTES.md](RELEASE-NOTES.md): what changed, and what to do before or after the move).

### Review rules

The queue and the head gate can also judge which lenses a change needs, its findings and its review rounds, from a
`review` block in the project's queue config. Turn it on in this order: release, pin, then config
([pr-queue README](actions/pr-queue/README.md#turning-it-on-release-pin-then-config)), in `shadow` first: a release
that does not know the key refuses the whole config.

### Outside a workflow

A project's tools that run outside a workflow (a deploy script, a local check) use the same code from the same
Expand Down
16 changes: 16 additions & 0 deletions fork-ci/RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,22 @@ nothing.

## After ci/v14

### pr-queue and head-check: review findings, rounds and `override_authors` (#740)

With a `review` block, the gate also judges the review itself from the lens comments. With `findings: true`, a lens's
newest report needs a findings section (`blocker:` and `major:` lines, or `findings: none`), and a blocker or major in
it fails the head. A round is a lens read of a different own change (a queue update adds none): from
`rounds.approach_at` the approach lens is required, and past `rounds.max` a person decides. The new optional key
`review.override_authors` lists the logins whose override comment counts as a person's (empty or left out: none
does). In `shadow` the check summary only adds a row "findings and rounds (shadow): they would have said: ...". Without
a `review` block nothing changes. First in the release after `ci/v20`.

**Upgrade:** `ci/v20` and older refuse a config with `override_authors`: move every pin first, then add the key
(pr-queue README, "Turning it on: release, pin, then config"). A config already in `enforce` with `findings: true`:
after the move, a required lens whose newest report has no findings section fails the head, so have the lens prompts
write `blocker: none` and `major: none` first, or switch to `shadow` before the move. In both modes a head whose
rounds cannot be judged (an error while reading the lens comments) now fails instead of passing on the old rule.

### handoff-put and handoff-get: a file handed from one job to a later job of the same run (#247)

- New actions [`handoff-put`](actions/handoff-put/README.md) and [`handoff-get`](actions/handoff-get/README.md). put
Expand Down
8 changes: 8 additions & 0 deletions fork-ci/actions/head-check/gate-caller.example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
# the pull request to the gate as a number, nothing more. Reviews and inline review comments start it through the
# review trigger (review-trigger.example.yml, copied next to this file; README.md, "Run again after a review"): on its
# finished run the gate looks the pull request up by that run's head.
# In a public repository GitHub blocks pull_request_target (from 2026-12-02) unless a repository Actions policy allows
# it for exactly this file (README.md, "The gate", setup step 4): keep the file name the policy names.
# Review rules (a `review` block in the config): release, pin, then config, as in ../pr-queue/README.md, "Turning it on:
# release, pin, then config". Pin the release first: an older one refuses the whole config.
name: Head gate

on:
Expand Down Expand Up @@ -50,5 +54,9 @@ jobs:
pr: ${{ format('{0}', github.event.pull_request.number || github.event.issue.number || inputs.pr) }}
config: .github/pr-queue.json
check-name: CHECK_NAME
# In shadow (or with no review block) these names decide. In enforce the config's path rules name the lenses and
# these are required as well; empty this only after the base's config is in enforce. Empty, it is no floor: a
# change only zero-lens rules match (`**/*.md` in review.recommended.json, AGENTS.md too) merges with no lens
# (the guide, step 5).
required-lenses: | # one lens name per line; none = the gate refuses, unless the config's review block is in enforce
LENS_NAME
Loading
Loading