You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Secret sweep: a re-run does not find its own earlier attempt's record #950
What was meant to be shown: a re-run of a secret sweep reads its own earlier attempt's record ("record from run "), the path #703 describes.
What happened live: one normal sweep run was dispatched and re-run once. Attempt 1 correctly found no earlier record (main had been rewritten since the last sweep). Attempt 2 also said "no earlier sweep kept a record", although attempt 1's record still existed. The log does not say why. Two candidates:
the called (reusable) workflow does not see the caller's GITHUB_WORKFLOW_REF, so the ref filter drops the record; or
the run's artifact list does not show an earlier attempt's record at that point.
It stays safe either way (a re-run falls back to the empty record or the newest earlier sweep, so nothing is skipped), but the own-record path is unproven and the sweep header still describes it.
To do:
On a re-run, log whether the workflow ref matched and how many of the run's own records were listed.
Re-run one sweep once and read that log.
Either fix the lookup, or change the header to describe what really happens.
Activity
fix(secret-sweep): alert group never the workflow's; header says re-r…
fix(secret-sweep): sweeps of a ref one at a time; a reset run never f…