Skip to content

builtinTools guard and threadRoles wiring: follow-ups from #927/#928 reviews #946

Open

Description

@scuttletoby

Small follow-ups from the round-2 reviews of #927 and #928 (both SAFE TO MERGE).

  1. apps/server/src/fork/claudeMcpProfile.ts:138 (fork: MCP profile builtinTools "none" (assistant PR 1) #927): the builtinTools "none" guard still allows a call without looking at the tool when hook_event_name is not "PreToolUse". The SDK always sets it today and tools: [] plus disallowedTools are the main barrier, so this is defence in depth: drop that early allow so only mcp__ tools pass. Test it.
  2. Calm sidebar part 1: threadRoles and calmSidebarEnabled settings #928: no test fails if ThreadRoleTargets.layer is dropped from layerRuntimeServices in forkLayers.ts (the app would then refuse every new role, writing nothing). Add an end-to-end check in the later calm-sidebar Settings PR.

Reports: #927 (comment), #928 (comment).

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions