Skip to content

review kit: follow-ups from the #845 lens round 3 #914

Open

Description

@scuttletoby

Follow-ups from Lens A round 3 on #845 (verdict SAFE): #845 (comment)

  1. Minor: fork-kit/review/SKILL.md:98,106 vs REVIEW.md:63 and lib/review_kit.py:223: the skill no longer says what happens to a fix that is not nit-only once lens_rounds is used up (e.g. minors: same-round, last round finds a minor whose fix touches code). Add one sentence: the orchestrator checks such a fix itself and posts the override; a blocker or major left over counts as stuck.
  2. Minor: fork-kit/review/SKILL.md:89 says the override counts "only from the account with" override.author_association; that is a kind of account, and the gate also needs the comment never edited and not hidden (lens.py override_sha). Use COMMENTS.md:63's wording.
  3. To check: the kit's check said the fork has no .github/pr-queue.json and fell back to default rules. The fork's review config is .github/fork-pr-queue.json. Check whether the kit should be pointed at that file (config path from project config) so check uses the fork's real rules.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions