Skip to content

Review rules as a fork feature: finish the judge (C3, C4) and the lens tools (T3-T5) #888

Open

Description

@scuttletoby

What: review rules as a fork feature. A project's config says which review lenses a change needs (by changed path and tier), the merge gate judges it, and T3 tools start lenses, record their reports and arm the PR, so the rules are enforced by code and not by the orchestrator's memory.

Why the owner wants it: reviews decide whether unattended work is safe to merge; today much of it is prose rules and a project-specific gate.

Already built: C1 config #301, C2 path judge #340 (+ #359), T1 contracts #291, T6 Settings panel #318 (+ #372), shared logic on shared vectors #781, release guide #778, general review kit #790. Open: T3a lens_start logic PR #825, general review skill PR #845, follow-ups #797 #799 #841.

Left (checklist):

  • C3 judge: rounds, approach lens, blocker: / major: and state: lines
  • C4 release tag, gate caller example, docs
  • T3 lens_start (PR Review rules T3a: lens_start plan, prompt, refusals and request ids (pure logic) #825 first)
  • T4 lens_report: server-written header, real commit
  • T5 lens_arm: refusals, ready, pinned auto-merge, check wait
  • Each project pins a release, runs the review block in shadow mode, then enforce, and deletes its old gate code
  • Outside reviewers as a config key

Open owner decisions: #81 #82 #99 #100.

Related: #848 (one merge path), #862 (batched merge queue), #865 (look-alike lens comments), #870 (orchestrator logic as software).

Done when: every project's merge gate reads one review config from the fork, lenses are started and recorded by T3 tools, and a PR without its required lenses cannot merge.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions