You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Seam list: refuse duplicate keys and dropped announced lines; #804 leftovers #813
Left over from the fix round of #804 (lens: #804 (comment)), plus a seam-list gap found on the way.
1. Seam checker: refuse duplicate keys in .github/fork-seams.json
fork-seam-check.cjs reads the list with JSON.parse, which silently keeps the last of two equal keys. If two PRs each add an entry for the same upstream file (as #807 and a later HO5 re-announce would for threadActionMenu.logic.ts, useThreadActionMenu.ts and Sidebar.tsx), the earlier entry's lines vanish with no error, and the checker then judges the file by half a list.
Wanted: the checker (and its test file) refuses a list with a duplicate key under files (or any other section), naming the key, so the second PR must merge its lines into the existing entry.
2. A merge must not silently drop another PR's announced seam lines
#777's squash merge, from a branch made before #774, dropped every HO5 line #774 had announced (.github/fork-seams.json at 73f3a76 vs e0e01b9), and nothing noticed. #807 now restores them by hand. Wanted: a check on each PR (and on main after a merge) that every announced line on the base branch is still in the PR's list, either still announced or moved to added with its code, unless the PR says it removes it (for example an expired announcement). A merge must not silently drop another PR's announced seam lines.
The "what this pick gives" note and the "wider than the parent's" warning in Settings → Fork can only be worked out for threads loaded in this window's environment. For a thread id that is not loaded, the panel says the comparison cannot be told (a pick is never cut down to the parent's either way). Showing it for unloaded threads would need the server to resolve it.
Also from the #939 code lens (#939 (comment)): the duplicate-key error should name where the key is (which file, under files or pending), and three paths need tests: the drop check falling back to main's list, a pending-file edit that also changes its ceiling or lost entry, and a pending-file edit with an unparseable own list.
Activity
scuttletoby commentedon Nov 22, 2026
PR #939 covers parts 1 and 2 (it now says "Part of #813"). Still open here:
fork/mcp-profile-thread-menu).🤖 Generated with Claude Code
scuttletoby commentedon Nov 22, 2026
Also from the #939 code lens (#939 (comment)): the duplicate-key error should name where the key is (which file, under
filesorpending), and three paths need tests: the drop check falling back to main's list, a pending-file edit that also changes its ceiling orlostentry, and a pending-file edit with an unparseable own list.🤖 Generated with Claude Code