Skip to content

Secret sweep: review follow-ups from #782 #791

Closed

Description

@scuttletoby

Minor findings from the two reviews of #782 (Lens A: #782 (comment), Lens B: #782 (comment)). None blocks; #782 is SAFE in both.

  1. Header wording (.github/workflows/fork-secret-sweep.yml:20-22): it can be read as "a re-run repairs an undone reset". It does not; say "a new run by hand with reset_record, not a re-run". Also: the comment says "first attempt" where it means "newest earlier attempt". (A1, A4, B nit)
  2. An undone reset is silent: a sweep that starts while a reset run is going on can undo the reset, and nothing warns about it. It never causes less scanning than before the reset, but the owner cannot see it happened. Options: a per-ref concurrency group on the sweep, or a run-name marking reset runs so a normal sweep that sees an unfinished earlier reset takes none failed. (A2)
  3. Live check after merge: re-run a sweep and look for the notice "record from run ", to confirm GITHUB_WORKFLOW_REF in the called workflow is the caller's. If it is not, it fails safe, but fix(secret-sweep): guard the sweep record's partial writes and reads (#703) #720's re-run progress silently stops. (A3, B2)
  4. Reset re-run can lose the reset: if attempt 1 kept no record and one read in attempt 2 (tag check or listing its own record) fails, the next sweep reads the record from before the reset. Two failures in a row, and the run goes red. Fix: in a reset run, fall back to the empty record on any read failure. (B1)
  5. Timeout check skips quietly if the time-limit line it looks for is reworded; make it fail instead. (B nit)

🤖 Generated with Claude Code

Activity

  1. scuttletoby commented on Nov 22, 2026

    @scuttletoby
    OwnerAuthor

    Point 3 (live check of a re-run reading its own earlier record) did not confirm; it continues in #950. The other points are done in #948.

    🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions