Skip to content

fork-ci declared test formats: minors from the #784 reviews #789

Open

Description

@scuttletoby

Follow-ups from the two reviews of #784 (lens A, lens B). Both SAFE, no blocking or major findings.

  1. stage-preview-bundle.test.py is run by a plain python3 step, so its unittest word in .github/fork-ci-tests.txt (around line 149) is never read. The list header's "judged by this word alone" is not true for that line: run it through the wrapper, or say so beside the line.
  2. An ok lines test counts its own results (already true on main).
  3. The list does not refuse a file listed twice (already true on main).
  4. The error message at .github/scripts/fork-ci-tests.cjs:180 reads awkwardly.
  5. The fork CI: each listed Python test declares its format (unittest or ok lines), judged by it alone (#702) #784 body says fork-ci-result reads the format in each record; it never does (body text only).

Part of #702.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions