Skip to content

Fork CI re-run: leftover minors from #707 reviews #709

Closed

Description

@scuttletoby

Leftover minor points from the round-2 reviews of #707 (automatic re-run of fork CI after known infrastructure failures, #130). None blocks; each fails closed today or is rare.

  • A pass that stops while opening the tracking issue (issue created, reply lost) can leave two tracking issues on the next pass.
  • The "memory full" box can be a slice several jobs share, so another job's OOM kill can count for this one.
  • If GitHub's annotation cap drops the real memory note, a fake one printed by a step could count.
  • A start probe step that stalls skips the job's tests and turns it red.
  • A person's re-run of a run older than 6 h is never looked at.
  • The runbook claims "each rule line pinned"; a few time-limit and stall lines still have no test.
  • The Fix comment's "nothing reads .git/config" is wrong: the sync check's git ls-remote runs in the checkout and sends the token (only to github.com, so harmless).

Review comments: #707 (comment) and #707 (comment)

🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions