Skip to content

Seam check follow-ups from #621: refuse a raised list count in the PR run, test gaps, docs #626

Closed

Description

@scuttletoby

Follow-ups from the two reviews of #621 (seam list exact from upstream):
lens A #621 (comment) and lens B #621 (comment)

Major (lens B 1, lens A minor 1): the PR rule judges only a list change that lowers a count (.github/scripts/fork-seam-check.cjs:585, if (dropped <= 0) continue;). A PR that raises its list count without adding the line, or removes a line still in use, passes its own run; the spare copy then stops the next fork-follow instead. Refuse it in the PR run: compare the list against the PR's own added lines both ways. Fits with #599 (upstream base for the seam check); #599 also has a text conflict with #621 in fork-seam-check.cjs, so whichever lands second needs a hand merge.

Minors:

  1. Untested branches and surviving mutants (lens B minor 1, lens A minor 3: the refusal wording branch).
  2. Stale branch: in a PR run, count comes from main's list while dropped comes from the branch; the number can be off by one (lens A minor 2, lens B minor 2). Fails safe. Add "(update the branch from main if main's list changed)" as findSeamBreaches does.
  3. docs/fork/updates.md: forks adopting this checker should run --from-upstream <upstream base> HEAD once and fix their list before updating the checker; otherwise one fork-follow run stops.
  4. CI does not run fork-follow.test.sh on PRs; consider adding it to the Fork kit tests job (mind Fork kit tests: job is near its 10-minute limit; a slow runner timed out #623's time limit).
  5. Note: fork seam check: follow-ups from #277 round 2 (moved/deleted lines, indentation, rename, tests) #311's old plan to move the seam lines out of serverSettings.ts is replaced by the exact-list rule, not done.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions