Skip to content

Seam check: #506 lens follow-ups (exact pending ceiling, summary wording, tests) #510

Closed

Description

@scuttletoby

From the two lenses on #506 (both SAFE WITH NITS: #506 (comment) and #506 (comment)).

  1. Low, fork-seam-check.cjs:359-360: a PR may set a "pending" ceiling lower than the fork lines left, or delete the entry while lines remain, and still pass; the next nightly then refuses main. Refuse anything other than the exact expected value (both lenses; one-line fix). Fails closed today.
  2. Low, fork-follow.sh:216-221: the run summary says "Committed into the series" before the lowered list is re-checked; on a later failure nothing is pushed but the summary claims the commit. Write it after the check passes.
  3. Low, fork-seam-check.cjs:812: a pending file with no fork lines left that a "lost" entry still names keeps its old ceiling; the next same-base run blocks until a PR moves it to files.
  4. Nit, fork-seam-check.cjs:196-199: the "update the branch from its base" hint shows even when updating would not help.
  5. Nit: neither seam check runs on merge_group; strict required checks (Owner: require PR branches to be up to date before merging into main? (recommend yes) #444) cover it today, say so in the docs instead of "may".
  6. Tests (end-to-end, not only unit): re-run of the same rebase moving to the earlier release; the "still lowers again" refusal; lowered + raised count in one run pushing nothing; lowering a "lost" count through fork-follow.

General vs project: general.

Activity

  1. added a commit that references this issue on Nov 21, 2026
    a263d58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions