You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Queue cache: HEAD's .gitattributes reaches merge-tree; GIT_EXEC_PATH kept on local calls (#447 lens follow-ups) #450
major (older than fix(fork-ci): queue and gate drop GIT_ATTR_SOURCE and the job's git programs (#442) #447, not reachable from a PR): a bare repo's HEAD is an attribute source for merge-tree (git 2.43 reads HEAD:.gitattributes in a bare repo). The gate builds a fresh repo each run (safe). The queue's kept cache is not: cache_problem (pr_queue.py:494) never checks HEAD. The lens planted HEAD: ref: refs/queue/evil at a commit with * merge=union; the cache check still passed and holds() went False -> True (a union-merged conflict accepted). Who: an earlier same-user job on the self-hosted runner, the actor the cache check already defends against. Same for head_check.py --bare on a caller-cloned repo. Fix: GIT_ATTR_SOURCE = empty tree 4b825dc642cb6eb9a060e54bf8d69288fbee4904 in GIT_ENV (pr_queue.py:80; lens checked it restores False) and/or cache_problem refuses an unexpected HEAD. Test the planted-HEAD case red first.
minor: Queue.git (pr_queue.py:491) passes its https remote on every call, so local calls (merge-tree, cat-file -e, rev-parse) keep GIT_EXEC_PATH; RELEASE-NOTES (fork-ci/RELEASE-NOTES.md:21-23) and the git_env docstring say they drop all. Fix: a fetch= flag set only on the two fetch calls (or fix the wording).
nit: head_check.py:86 accepts --remote https://... without --bare (help says "with --bare"); then checkout mode drops the vars, contrary to "keeps them as before". Refuse it or fix the help.
nit: strict UTF-8 decode also applies to git's stderr (head_check.py:85); a translated git error under a non-UTF-8 locale could traceback (still fails closed). Set LC_ALL=C on these calls.
nit: GIT_SSL_*, GIT_TRACE_CURL/GIT_TRACE_REDACT, GIT_HTTP_* are kept on token-carrying https fetches; the gate's git fetch failed: {stderr[:300]} could carry trace text into the public check-run summary. Drop the trace vars on token fetches, or redact.
nit (docs): an old CLI run on a private repo with no read token that relied on GIT_ASKPASS now prints "git fetch failed ... STATE stays" each run instead of a named refusal (RELEASE-NOTES Upgrade covers it; consider a named message).
State question for the fix: the cache kept from runs before the fix (planted or stale HEAD), a run stopped between fetch and merge-tree, an empty or missing HEAD in a fresh bare repo.
Activity
fork-ci: HEAD attributes ignored in the queue cache; local git calls …
fork-ci: HEAD attributes ignored in the queue cache; local git calls …
fork-ci: HEAD attributes ignored in the queue cache; local git calls …