Skip to content

#426 follow-ups: upstream e2e file taken for a fork file, list path validation, operator messages #432

Closed

Description

@scuttletoby

Follow-ups from the two SAFE lenses on #426 (merged 2b1c3e9): trust #426 (comment), state #426 (comment).

  1. major (state 1, blocks the next fork-follow): from upstream nightly …4695 on, upstream has scripts/scenarios/fork-title-regenerates-from-inherited-history.e2e.ts; its name matches the fork-file pattern, so fork-follow stops after the rebase (fork-seam-check.cjs:356, fork-follow.sh:465). Fix: add !scripts/scenarios/fork-title-regenerates-from-inherited-history.e2e.ts to forkFiles (the lens checked main's check stays exit 0). Better: a general rule so an upstream file is never taken for a fork file by name alone.
  2. minor (state 2): the PR-list format guard does not check that files/pending keys are real repo paths ("", /abs, ../x, :(glob)x pass, then every later run crashes with exit 3) (fork-seam-check.cjs:388, :404).
  3. minor (trust 1): in a pending file with a lost entry, a PR can put back one gone upstream line and delete a different one; both counts stay the same. Counting cannot tell lines apart; at least correct the "20 lines can move unseen" claim in docs, or track lost lines by content.
  4. minor (trust 2): the ruleset does not require up-to-date branches, so a list-editing PR that went green before a list change can merge into a malformed list. Re-run CI of hold-work: a marker guards a held or stopped copy's home in the CLI; tests and docs (#368) #398 and remote delegate: record and follow a launched child even if the call is interrupted (#386 part 1) #412 before merging; consider a list-hash check.
  5. minor (state 3): when a count rises after a rebase, the message gives a PR-author fix, not what the operator should do next.
  6. nits: duplicate keys accepted (JSON keeps the last; trust 3); an unknown key with a newline can forge a workflow annotation line in the log (trust 4); fork-follow.sh:198 seam refusal lacks "The series was left as it is" (state 4); two mutations were killed only by the test file failing to load (state).
  7. note: Seam list: no green path to add a new seam line (announce first, then add) #409's planned announced key must be added to the known keys (trust 5).

Part of #325.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions