Skip to content

#404 minors: settings-table reader test gap (scopes!==1), comments counted as scope #417

Closed

Description

@scuttletoby

Minors from the lens on #404 (#404 (comment); SAFE). All are in .github/scripts/fork-changes-list.cjs.

  1. Minor (:66-68): the || scopes !== 1 half of the per-row check has no test. With it removed, a row such as scope: SCOPE, key: "x", note: { scope: "server", key: "a" } reads silently as server.a. Add that test case.
  2. Minor (:66-67): scope: is counted anywhere in the row's text, comments and nested values included. A row whose real setting comes from a spread, while a comment spells scope: "server", key: "a", passes with the wrong id. Strip comments before counting, and refuse a spread anywhere in a row. Contrived; not a regression.
  3. Nit (:20): two entries on one line ({ scope: "client", key: "b" }, { ...EXTRA },) read as one row, so EXTRA is lost. Only an unformatted file gets there, and lint catches it first. Refuse more than one { per line.
  4. Nit (:70): when a row's closing }, is not recognised, the error reads 2 "scope:" but 2 read. Name the real cause.
  5. Nit: the two-space indent on a row's }, has no test. Loosening it only causes false reds.

Activity

  1. added 2 commits that reference this issue on Nov 21, 2026
    dbaac57
    42dde8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions