Skip to content

Owner question: merge #277 past its red schema check (it changes the check's workflow)? #344

Closed

Description

@scuttletoby

Recommendation: merge #277 as it is (squash), past the red "No database schema changes" check.

#277 (fork lines in upstream files: the seam check) is ready. Its head bf57fecc passes every check except "No database schema changes". That check is red by design: #277 adds the seam step to .github/workflows/fork-checks.yml and changes fork-schema-check.test.cjs, and the check refuses any change to itself. Its message says: "Only the owner may do that: the check stays red, and the owner merges past it."

What changed in those two files:

  • fork-checks.yml: runs fork-seam-check.test.cjs in "Test the check", and adds the step "Fork lines in upstream files" right after "Refuse changes to upstream files the fork leaves alone". Both earlier reviews confirmed this YAML.
  • fork-schema-check.test.cjs: it used to require exactly one DEFAULT_SHA line; now every DEFAULT_SHA must be github.sha, so a second one that points at the PR head still fails.

One more choice in the PR: commit bf57fecc records 4 files that #294 and #310 changed on main as pending ceilings in .github/fork-seams.json (ProviderRegistry.test.ts 14 lines, managedProvider.test.ts 39, managedProvider.ts 8, snapshot.ts 2). Without it, the nightly upstream-follow run would fail as soon as #277 merges. Recommendation: keep it; moving those lines under real seams is follow-up #311.

Options:

  1. Merge fork seam check: every upstream file counted, allow list from main (#242 #189) #277 as it is (recommended).
  2. Drop commit bf57fecc first (the nightly then fails until fork seam check: follow-ups from #277 round 2 (moved/deleted lines, indentation, rename, tests) #311 is done).
  3. Hold fork seam check: every upstream file counted, allow list from main (#242 #189) #277.

Reviews: 4 review rounds; the last one was SAFE at 2951ba79. Since then: lint fixes in comments only, the workflow step above, a rebase onto main (kept #323's seam lines), and the pending commit.

🤖 Generated with Claude Code

Activity

  1. scuttletoby commented on Nov 17, 2026

    @scuttletoby
    OwnerAuthor

    Owner decision 2026-11-17: yes. #277 may merge with the "No database schema changes" check red (it changes that check's own workflow). It merges once the rest of its CI is green on a head updated onto current main.

    🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions