Skip to content

fork-seam-check: follow-ups from #277 round 4 (after-rebase gap, hint text match, note visibility) #325

Closed

Description

@scuttletoby

not a lens: follow-ups from the round-4 correctness lens on #277 (verdict SAFE, head 2951ba79): #277 (comment)

  1. Unflagged stretch after a rebase. When upstream adopts a pending fork line, the after-rebase run only logs a note. Until the next nightly, a PR can edit an upstream line of that file in place; it passes its own check and the next nightly turns green, so nothing records it. Not worse than main today. fork seam check: follow-ups from #277 round 2 (moved/deleted lines, indentation, rename, tests) #311's planned fix does not cover it (the rebase shrank the file, not a PR). Cheapest fix: fork-follow commits the lowered ceilings into the rebased series itself.
  2. Ceiling hint matched by text. Ceiling refusals are recognised by their message text, so a file whose name contains that text gets the wrong "lower the ceiling" advice. The check still fails; only the hint is wrong.
  3. After-rebase note only in the log. It should also go to the report / step summary.

Activity

  1. added 3 commits that reference this issue on Nov 18, 2026
    62d206e
    6f259fa
    09099a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions