You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-ups from the round-2 lenses on #277 (fork seam check): bypass #277 (comment) and state #277 (comment). The one major (ceiling left too high) is fixed in the PR. None of these blocked.
Deleted or moved lines inside seam and pending files pass both runs (biggest gap left; 64 pending files + the seam files). Deleting a guard line, or moving it below the code it protects, passes. Fix idea: a second ceiling per file for upstream lines removed (or an ordered compare of the upstream lines).
Indentation-only changes pass in unlisted upstream files. In YAML/Python indentation changes behaviour (e.g. moving if: false from a job to a step in upstream's .github/actions/setup-ci-deps/ci-changes users). Fix: keep leading spaces when comparing lines (drop only trailing blanks).
Two PRs from the same main point can each use one seam-line allowance. The nightly catches it only after both merge. Fix: also count copies at the base tip, or require up-to-date branches.
Untested guards (mutations survive): the PR run reading the removed-workflows list from the PR instead of main (security-relevant); widening the fork-workflow exception to any path containing fork-; the exact ceiling boundary (now partly covered); deleting an upstream file with a fork-style name (not a workflow) from upstream.
Upstream renames a pending or seam file: the rebase is clean, but no list version passes both fork-follow checks (before and after); only a hand rebase gets past. Fix: a listed path neither base nor head has = a note, not a refusal (or an explicit rename map).
Fork of this fork: "from upstream" is decided by "the base has no list"; a downstream fork following this fork never reads its own list. Fix: an explicit --from-upstream flag passed by fork-follow.
Generic pinned lines in serverSettings.ts (}, };, ) {, /**, */) go against "keep seam lines specific". Moving those 29 lines out of serverSettings.ts (the planned follow-up) removes them.
Planned in the PR body: move the 29 serverSettings.ts lines into fork files; lower ceilings as lines move out (now enforced).
not a lens: one more follow-up from the round-3 lens on #277 (minor 2): a PR that shrinks the fork lines in a "pending" file should lower that file's own ceiling in the same PR. Today the PR passes and the next PR (or the next fork-follow run from the new base) is the one refused for the stale ceiling. Fix idea: in PR mode, refuse (or at least note) when the head has fewer fork lines than the ceiling listed at the base, naming the new value.
Activity
scuttletoby commentedon Nov 17, 2026
not a lens: one more follow-up from the round-3 lens on #277 (minor 2): a PR that shrinks the fork lines in a "pending" file should lower that file's own ceiling in the same PR. Today the PR passes and the next PR (or the next fork-follow run from the new base) is the one refused for the stale ceiling. Fix idea: in PR mode, refuse (or at least note) when the head has fewer fork lines than the ceiling listed at the base, naming the new value.
🤖 Generated with Claude Code
Refs #311, Fixes #325, Fixes #416: seam check follow-ups (#506)
Refs #311, Fixes #325, Fixes #416: seam check follow-ups (#506)
Refs #311, Fixes #325, Fixes #416: seam check follow-ups (#506)
Refs #311, Fixes #325, Fixes #416: seam check follow-ups (#506)
fork seam check: refuse spare seam copies (#311 items 7/8) (#621)
fork seam check: refuse spare seam copies (#311 items 7/8) (#621)