Fix index out of bounds panic in glTF animation export - #75
Open
null-port wants to merge 1 commit into
Open
Conversation
Use bounds-checked .get() instead of direct indexing when accessing object_curves, matching the approach already used by the COLLADA exporter. Skips animation export for objects whose index exceeds the animation's curve count rather than panicking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
null-port
marked this pull request as ready for review
April 7, 2026 03:57
Owner
|
What game did you test with? |
Author
|
I tested with Nintendogs - Lab & Friends (USA) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/convert/gltf/mod.rswhen a skeleton references more objects than an animation has curves for.get()+ fallback; this applies the same bounds-checking approach to the glTF exporterTest plan
convert -f glb --all-animations --more-texturescompletes successfully on a ROM that previously panicked (440 GLBs written vs crash)🤖 Generated with Claude Code