perf: avoid cloning CPU witness MLEs#1342
Open
hero78119 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
left-over from #923. CPU trace commit cloned large witness MLEs before proving, adding avoidable memory traffic on the prover hot path.
Design Rationale
Keep committed witness MLEs behind
Arcand drain/transport ownership where possible, avoiding deep clones without changing proof semantics.Change Highlights
ceno_zkvm: returnArcwitness MLEs from trace commit and consume structural MLEs during transport.ceno_zkvm: keep GPU trait shape aligned while preserving existing GPU behavior.Benchmark / Performance Impact
Operation
Layer
Benchmark command(s):
Environment: local x86_64 Linux, release build, local
../ceno-gpu/cuda_halpatch for GPU validation.raw data:
3.272s + 3.670s; GPU shards0.624s + 0.568s3.336s + 3.260s; GPU shards0.593s + 0.593sTesting
Risks and Rollout
Low risk: prover-side ownership change only. Rollback is reverting the
Arcwitness-MLE plumbing.Follow-ups (optional)
None.
Copilot Reviewer Directive (keep this section)
When Copilot reviews this PR, apply
.github/copilot-instructions.mdstrictly.