Conversation
cyfung1031
commented
May 6, 2026
Comment on lines
+1007
to
+1013
| // const nwError2 = await runCase( | ||
| // { | ||
| // url: `https://nonexistent-domain-abcxyz.reject/abc.html`, // disallowed domain | ||
| // }, | ||
| // { abortAfterMs: 500 } | ||
| // ); | ||
| // assertDeepEq(nwError2.events, ["onerror", "onloadend"], "abort fires onerror then onloadend"); |
Collaborator
Author
There was a problem hiding this comment.
@CodFrm 这个跟 权限验证 的设计有关。我不知道你会怎么改（上次改了后你又改回来之类。。不想搞）。这个PR我先不处理。 你可以先合并日后再处理
Collaborator
Author
Member
There was a problem hiding this comment.
没有和权限验证有关系吧，是因为出现error提前refCleanup了导致连接断掉，没有再发onloadend了？看起来没什么问题
我改的话，可能会更看重 可读性、高内聚、低耦合 一些
Collaborator
Author
There was a problem hiding this comment.
有关系的。 verify 里不是跑 xhr 那块事件流程
（ xhr 事件流程在 src/app/service/content/gm_api/gm_xhr.ts 跑 - 你说得对，我找了很久才找到 「出现error提前refCleanup了导致连接断掉」；
verify 的reject 在 src/app/service/service_worker/gm_api/gm_api.ts 跑 ）
但在TM，即使是权限问题，它最后还会有 loadend
在SC就 throw Error 后没了
( 另外，之前 verify 报错后没有 disconnect ... )
我改的话，可能会更看重 可读性、高内聚、低耦合 一些
不过我都修改好了。至少能跑
写法接不接受就看你了
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist / 检查清单
Description / 描述
Screenshots / 截图