fix(ci): update simulator destination to iPhone 17

[prince-0408]

Closes #656

Summary

Fixes the CI test failure where the runner was unable to locate the iPhone 16 (OS: 18.5) simulator destination.

Changes

• Updated .github/workflows/ci_test.yaml to target iPhone 17 (omitting the exact OS version). Omitting the OS parameter allows xcodebuild to automatically resolve to the latest available iOS simulator of that model, making it much more robust against runner updates.

Verification

• Verified locally that tests build and pass successfully using this destination specifier.

[github-actions]

Thank you for the pull request! 💙🩵

The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:

• Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
• If you're not already a member of our public Matrix community, please consider joining!
  • We'd suggest that you use the Element client as well as Element X for a mobile app
  • Join the General and iOS rooms once you're in
• Also consider attending our bi-weekly Saturday developer syncs!
  • Details are shared in the General room on Matrix each Wednesday before the sync
  • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

praise: Thanks so much for this, @prince-0408! I'll update the docs after this :) Really appreciate the issue and the quick response here 😊