Skip to content

feat: add language selection dropdowns to settings#52

Open
Mounil2005 wants to merge 1 commit into
scribe-org:mainfrom
Mounil2005:feat/language-selection
Open

feat: add language selection dropdowns to settings#52
Mounil2005 wants to merge 1 commit into
scribe-org:mainfrom
Mounil2005:feat/language-selection

Conversation

@Mounil2005

Copy link
Copy Markdown
Contributor

Contributor checklist


Description

Adds language selection UI to the settings panel so users can choose which language to translate from and to.
Add Language enum with 8 supported languages (EN, FR, DE, IT, PT, RU, ES, SV). Add from/to language pick_list dropdowns in settings panel above theme toggle. Resize settings panel to accommodate the two additional rows.

Files changed:

  1. scribe/src/state.rs: Added Language enum with 8 supported languages (English, French, German, Italian, Portuguese, Russian, Spanish, Swedish), with Display impl for dropdown labels. Added from_language and to_language fields to AppState.
  2. scribe/src/lib.rs: Re-exported Language from the crate root.
  3. scribe/src/bin/gui.rs: Added two pick_list dropdowns ("Translate from:" / "Translate to:") in the settings panel above the existing theme toggle. Settings panel now resizes to 160px height to accommodate the extra rows. Added FromLanguageSelected and ToLanguageSelected message variants.

Testing:
Ran cargo run --bin gui, opened settings panel, verified both dropdowns appear and are selectable.

Related issue

)

Add Language enum with 8 supported languages (EN, FR, DE, IT, PT, RU, ES, SV).
Add from/to language pick_list dropdowns in settings panel above theme toggle.
Resize settings panel to accommodate the two additional rows.
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Desktop team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Desktop rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Mounil2005 Mounil2005 marked this pull request as ready for review July 2, 2026 06:26
@Mounil2005

Copy link
Copy Markdown
Contributor Author

@andrewtavis Pls do let me know in case of any changes!

@andrewtavis

Copy link
Copy Markdown
Member

@henrikth93 or @Femimat: Would one of you want to do an initial review here?

@andrewtavis

Copy link
Copy Markdown
Member

Thanks so much for the quick work here, @Mounil2005! We'll try to bring this in in the coming days :)

@RyanPaulGannon

Copy link
Copy Markdown
Collaborator

@andrewtavis, would you like me to take a look? I don't want to hijack anything, just conscious I've done very little lately!

@henrikth93

Copy link
Copy Markdown
Member

@andrewtavis, would you like me to take a look? I don't want to hijack anything, just conscious I've done very little lately!

I was just gonna reply! If you want to Ryan, you can go ahead and do a review, otherwise I can look at it! :D

@andrewtavis

Copy link
Copy Markdown
Member

Happy to have a review here, @RyanPaulGannon :) Let's do that and then maybe @henrikth93 can review your work on #43 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to choose which language to translate to/from

4 participants