feat: add language selection dropdowns to settings#52
Conversation
Thank you for the pull request! 💙🩵The Scribe-Desktop team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
@andrewtavis Pls do let me know in case of any changes! |
|
@henrikth93 or @Femimat: Would one of you want to do an initial review here? |
|
Thanks so much for the quick work here, @Mounil2005! We'll try to bring this in in the coming days :) |
|
@andrewtavis, would you like me to take a look? I don't want to hijack anything, just conscious I've done very little lately! |
I was just gonna reply! If you want to Ryan, you can go ahead and do a review, otherwise I can look at it! :D |
|
Happy to have a review here, @RyanPaulGannon :) Let's do that and then maybe @henrikth93 can review your work on #43 😊 |
Contributor checklist
justcommand as directed in the testing section of the contributing guideDescription
Adds language selection UI to the settings panel so users can choose which language to translate from and to.
Add Language enum with 8 supported languages (EN, FR, DE, IT, PT, RU, ES, SV). Add from/to language pick_list dropdowns in settings panel above theme toggle. Resize settings panel to accommodate the two additional rows.
Files changed:
Testing:
Ran cargo run --bin gui, opened settings panel, verified both dropdowns appear and are selectable.
Related issue