Skip to content

Add an enter button to the command UI#48

Merged
andrewtavis merged 2 commits into
scribe-org:mainfrom
Femimat:add-enter-command-button
Jun 6, 2026
Merged

Add an enter button to the command UI#48
andrewtavis merged 2 commits into
scribe-org:mainfrom
Femimat:add-enter-command-button

Conversation

@Femimat

@Femimat Femimat commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

  • Added a CommandKind state for Translate, Conjugate, and Plural.
  • Selecting a command now records the active command and gives that button a selected visual state.
  • The input placeholder changes per command.
  • An Enter button appears to the right of the text input only after one of those commands is selected.
  • Added ExecuteCommand handling as the hook for future real command execution.
  • Added tests for command selection and keyboard capture behavior.

Related issue

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Desktop team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Desktop rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review June 6, 2026 08:34

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's looking great here, @Femimat! Thanks for your efforts to finish this up :)

note: I'll make another issue to take a look at some minor details about the UI. Feel free to pick it up!

@andrewtavis andrewtavis merged commit 591b8db into scribe-org:main Jun 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an enter button to the command UI

2 participants